Details

Reviewers

michal
kamil
ginsu
ashoat

Commits

rCOMM4160b885c356: [lib] Refactor thread reducer

Summary

issue: ENG-5814
We want to remove the thread related to the ks the user has logged in to / logged out of / had the cookie invalidated by.

Test Plan

Tested that when keyserverAuthActionTypes.success is dispatched the threads are deleted and replaced with the new ones
Checked that when a user logs out the threads are deleted.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jan 12 2024, 7:30 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 12 2024, 7:30 AM

inka added a parent revision: D10619: [lib] Refactor report store reducer.Jan 12 2024, 7:31 AM

Harbormaster completed remote builds in B25727: Diff 35576.Jan 12 2024, 8:18 AM

inka requested review of this revision.Jan 12 2024, 8:18 AM

ashoat added inline comments.Jan 13 2024, 6:06 PM

lib/shared/thread-utils.js
1807 ↗	(On Diff #35576)	Should this be in `lib/keyserver-conn/keyserver-call-utils.js`?

Move function

Harbormaster failed remote builds in B25753: Diff 35604!Jan 15 2024, 2:04 AM

inka added a child revision: D10628: [lib] Refactor user reducer.Jan 15 2024, 3:28 AM

Thanks for moving it! The name of the file is kind of weird given the use case here, but the family of functions there is very similar... I think it's good they're in the same file, and we might consider moving / renaming the file in a later diff

This revision is now accepted and ready to land.Jan 15 2024, 4:45 PM

We decided to have a single action for logging out of keyservers and identity.

Undo changes to logout

This revision is now accepted and ready to land.Jan 18 2024, 1:41 AM

inka requested review of this revision.Jan 18 2024, 1:41 AM

Harbormaster completed remote builds in B25875: Diff 35770.Jan 18 2024, 2:08 AM

ashoat accepted this revision.Jan 21 2024, 9:43 PM

This revision is now accepted and ready to land.Jan 21 2024, 9:43 PM

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B25990: Diff 35922.Jan 22 2024, 3:43 AM

Following D10609, make threadInfos in KeyserverAuthResult be RawThreadInfos

Harbormaster completed remote builds in B26069: Diff 36023.Jan 23 2024, 2:06 AM