Paths

Table of Contentst

Differential D10821

[web] add identity password login to traditional-login-form.react.js
ClosedPublic
Actions

Authored by varun on Jan 25 2024, 12:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 7, 1:26 AM

	Unknown Object (File)
	Wed, Oct 23, 5:12 AM

	Unknown Object (File)
	Wed, Oct 23, 3:58 AM

	Unknown Object (File)
	Fri, Oct 18, 3:37 PM

	Unknown Object (File)
	Fri, Oct 18, 3:36 PM

	Unknown Object (File)
	Fri, Oct 18, 3:36 PM

	Unknown Object (File)
	Fri, Oct 18, 3:36 PM

	Unknown Object (File)
	Fri, Oct 18, 6:55 AM

View All 51 Files

Subscribers

None

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMM963b5ab3584f: [web] add identity password login to traditional-login-form.react.js

Summary

can now successfully log in to the identity service from web with username/password if usingCommServicesAccessToken is enabled

registering users reserved on ashoat's keyserver will be handled in ENG-4033 and will be transparent to the user, so no changes will be needed here

Depends on D10817

Test Plan

successfully logged in to identity service from web modal. also tested that the correct error message is displayed if user isn't registered

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jan 25 2024, 12:07 PM

varun added inline comments.Jan 25 2024, 12:10 PM

lib/types/redux-types.js
401 ↗	(On Diff #36141)	realized i previously missed this
web/grpc/identity-service-client-wrapper.js
213 ↗	(On Diff #36141)	simplifying the error that we throw here so that it's easier to inspect in `identityPasswordLogInAction` the console log should give us enough context, anyway

Harbormaster completed remote builds in B26164: Diff 36141.Jan 25 2024, 12:26 PM

varun requested review of this revision.Jan 25 2024, 12:26 PM

varun added a child revision: D10827: [native] new AlertDetails.Jan 25 2024, 3:33 PM

ashoat accepted this revision.Jan 25 2024, 5:56 PM

ashoat added inline comments.

web/account/traditional-login-form.react.js
125 ↗	(On Diff #36141)	Can you add a screenshot of what this looks like? I want to make sure it doesn't overflow the bounds

This revision is now accepted and ready to land.Jan 25 2024, 5:56 PM

varun mentioned this in D10817: [lib] add identity password log in action.Feb 2 2024, 1:02 PM

rebase

Harbormaster completed remote builds in B26605: Diff 36762.Feb 6 2024, 9:21 PM

Screenshot 2024-02-08 at 12.26.24 AM{F1128612}

varun added inline comments.Feb 7 2024, 9:28 PM

web/account/traditional-login-form.react.js
125 ↗	(On Diff #36141)	shared a screenshot on latest revision. also this is the same text we have on line 99

Closed by commit rCOMM963b5ab3584f: [web] add identity password login to traditional-login-form.react.js (authored by varun). · Explain WhyFeb 7 2024, 9:57 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM963b5ab3584f: [web] add identity password login to traditional-login-form.react.js.

Revision Contents
Changeset List

Path

Size

lib/

types/

1 line

web/

account/

traditional-login-form.react.js

50 lines

grpc/

identity-service-client-wrapper.js

12 lines

Diff 36831

lib/types/redux-types.js

Loading...

web/account/traditional-login-form.react.js

Loading...

web/grpc/identity-service-client-wrapper.js

Loading...