we will need to create an object of this type for wallet login too, so moving the common code to a helper
Depends on D10959
Details
Details
successfully logged in to identity service on web, console logged DeviceKeyUpload to make sure it matched the contents in DDB
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/grpc/identity-service-client-wrapper.js | ||
|---|---|---|
| 291 ↗ | (On Diff #36665) | I don't think that adding a protocol to the name is helpful. Instead, we could mention which endpoint we're calling. |
| web/grpc/identity-service-client-wrapper.js | ||
|---|---|---|
| 291 ↗ | (On Diff #36665) | hmm but DeviceKeyUpload comes from the grpc-web codegen and isn't specific to the logInPasswordUserStart endpoint. we send this on loginWalletUser, loginPasswordUserStart, and registerPasswordUserStart. i'll rename it to loginDeviceKeyUpload since we don't support registration on web, but i think this could lead to confusion if we ever introduce another web client method that uses DeviceKeyUpload. |
| web/grpc/identity-service-client-wrapper.js | ||
|---|---|---|
| 291 ↗ | (On Diff #36665) | How about authDeviceKeyUpload? |
| web/grpc/identity-service-client-wrapper.js | ||
|---|---|---|
| 291 ↗ | (On Diff #36665) | sure i'm fine with that |