Page MenuHomePhabricator
Differential D10939

[native] deprecate generateAndGetPrekeys
ClosedPublic
Actions

Authored by varun on Feb 2 2024, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 7:35 PM
Unknown Object (File)
Sat, Mar 1, 7:35 PM
Unknown Object (File)
Sat, Mar 1, 7:35 PM
Unknown Object (File)
Feb 26 2025, 2:27 AM
Unknown Object (File)
Feb 18 2025, 11:19 AM
Unknown Object (File)
Feb 14 2025, 3:55 PM
Unknown Object (File)
Jan 30 2025, 5:35 PM
Unknown Object (File)
Jan 30 2025, 5:08 PM
View All 70 Files
Subscribers
tomek

Details

Reviewers
ashoat
kamil
marcin
Commits
rCOMM5979b1749203: [native] deprecate generateAndGetPrekeys
Summary

we can deprecate this method and related code

Depends on D10927

Test Plan

app builds successfully. also successfully registered a user calling the new validateAndGetPrekeys method instead of generateAndGetPrekeys.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
2 lines
NativeModules/
1 line
58 lines
Notifications/
BackgroundDataStorage/
2 lines
11 lines
_generated/
identity-service/
2 lines
schema/
1 line

Diff 36826

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...