Page MenuHomePhabricator
Differential D10939

[native] deprecate generateAndGetPrekeys
ClosedPublic
Actions

Authored by varun on Feb 2 2024, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:32 AM
Unknown Object (File)
Sun, Apr 6, 7:53 AM
Unknown Object (File)
Thu, Apr 3, 5:29 PM
Unknown Object (File)
Mar 1 2025, 7:35 PM
Unknown Object (File)
Mar 1 2025, 7:35 PM
Unknown Object (File)
Mar 1 2025, 7:35 PM
Unknown Object (File)
Feb 26 2025, 2:27 AM
Unknown Object (File)
Feb 18 2025, 11:19 AM
View All 73 Files
Subscribers
tomek

Details

Reviewers
ashoat
kamil
marcin
Commits
rCOMM5979b1749203: [native] deprecate generateAndGetPrekeys
Summary

we can deprecate this method and related code

Depends on D10927

Test Plan

app builds successfully. also successfully registered a user calling the new validateAndGetPrekeys method instead of generateAndGetPrekeys.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
2 lines
NativeModules/
1 line
58 lines
Notifications/
BackgroundDataStorage/
2 lines
11 lines
_generated/
identity-service/
2 lines
schema/
1 line

Diff 36826

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

use std::collections::HashMap; use std::collections::HashMap;
use tonic::Status; use tonic::Status;
use tracing::error; use tracing::error;
use crate::{ use crate::{
client_service::client_proto::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
constants::{ constants::{
CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY, CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME,
}, },
database::DeviceKeys, database::DeviceKeys,
grpc_services::authenticated::auth_proto::{InboundKeyInfo, OutboundKeyInfo}, grpc_services::protos::{
auth::{InboundKeyInfo, OutboundKeyInfo},
unauth::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
},
token::AuthType, token::AuthType,
}; };
pub struct DeviceInfoWithAuth<'a> { pub struct DeviceInfoWithAuth<'a> {
pub device_info: HashMap<String, String>, pub device_info: HashMap<String, String>,
pub auth_type: Option<&'a AuthType>, pub auth_type: Option<&'a AuthType>,
} }
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

use std::collections::HashMap; use std::collections::HashMap;
use tonic::Status; use tonic::Status;
use tracing::error; use tracing::error;
use crate::{ use crate::{
client_service::client_proto::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
constants::{ constants::{
CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY, CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME,
}, },
database::DeviceKeys, database::DeviceKeys,
grpc_services::authenticated::auth_proto::{InboundKeyInfo, OutboundKeyInfo}, grpc_services::protos::{
auth::{InboundKeyInfo, OutboundKeyInfo},
unauth::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
},
token::AuthType, token::AuthType,
}; };
pub struct DeviceInfoWithAuth<'a> { pub struct DeviceInfoWithAuth<'a> {
pub device_info: HashMap<String, String>, pub device_info: HashMap<String, String>,
pub auth_type: Option<&'a AuthType>, pub auth_type: Option<&'a AuthType>,
} }
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

use std::collections::HashMap; use std::collections::HashMap;
use tonic::Status; use tonic::Status;
use tracing::error; use tracing::error;
use crate::{ use crate::{
client_service::client_proto::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
constants::{ constants::{
CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY, CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME,
}, },
database::DeviceKeys, database::DeviceKeys,
grpc_services::authenticated::auth_proto::{InboundKeyInfo, OutboundKeyInfo}, grpc_services::protos::{
auth::{InboundKeyInfo, OutboundKeyInfo},
unauth::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
},
token::AuthType, token::AuthType,
}; };
pub struct DeviceInfoWithAuth<'a> { pub struct DeviceInfoWithAuth<'a> {
pub device_info: HashMap<String, String>, pub device_info: HashMap<String, String>,
pub auth_type: Option<&'a AuthType>, pub auth_type: Option<&'a AuthType>,
} }
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

use std::collections::HashMap; use std::collections::HashMap;
use tonic::Status; use tonic::Status;
use tracing::error; use tracing::error;
use crate::{ use crate::{
client_service::client_proto::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
constants::{ constants::{
CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY, CONTENT_ONE_TIME_KEY, NOTIF_ONE_TIME_KEY,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_CONTENT_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_KEY_PAYLOAD_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_NOTIF_PREKEY_SIGNATURE_ATTRIBUTE_NAME,
USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME, USERS_TABLE_DEVICES_MAP_SOCIAL_PROOF_ATTRIBUTE_NAME,
}, },
database::DeviceKeys, database::DeviceKeys,
grpc_services::authenticated::auth_proto::{InboundKeyInfo, OutboundKeyInfo}, grpc_services::protos::{
auth::{InboundKeyInfo, OutboundKeyInfo},
unauth::{
DeviceKeyUpload, IdentityKeyInfo, OpaqueLoginStartRequest, PreKey,
RegistrationStartRequest, ReservedRegistrationStartRequest,
ReservedWalletLoginRequest, WalletLoginRequest,
},
},
token::AuthType, token::AuthType,
}; };
pub struct DeviceInfoWithAuth<'a> { pub struct DeviceInfoWithAuth<'a> {
pub device_info: HashMap<String, String>, pub device_info: HashMap<String, String>,
pub auth_type: Option<&'a AuthType>, pub auth_type: Option<&'a AuthType>,
} }
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...