[native] rename siweServerCall
ClosedPublic
Actions

Authored by varun on Feb 5 2024, 9:53 PM.

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMM77322b6f66d2: [native] rename siweServerCall

Summary

prefixing with legacy to avoid confusion later

Depends on D10958

Test Plan

ran flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 5 2024, 9:53 PM

varun added a child revision: D10960: [web] factor out creation of DeviceKeyUpload.

Harbormaster completed remote builds in B26527: Diff 36664.Feb 5 2024, 10:11 PM

varun requested review of this revision.Feb 5 2024, 10:11 PM

It would be helpful if you linked a Linear task describing why we need to change that or explain what the plan is. I guess we're going to introduce a new, similar hook, but I can't be sure.

This revision is now accepted and ready to land.Feb 6 2024, 12:56 AM

In D10959#316129, @tomek wrote:

It would be helpful if you linked a Linear task describing why we need to change that or explain what the plan is. I guess we're going to introduce a new, similar hook, but I can't be sure.

good point. i'll keep this in mind going forward

https://linear.app/comm/issue/ENG-4361/have-clients-call-identity-service-login-wallet-user-rpc-when-logging

Closed by commit rCOMM77322b6f66d2: [native] rename siweServerCall (authored by varun). · Explain WhyFeb 7 2024, 9:58 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM77322b6f66d2: [native] rename siweServerCall.