Page MenuHomePhabricator
Differential D10740

[native] rename login -> logIn where appropriate
ClosedPublic
Actions

Authored by varun on Jan 19 2024, 6:59 AM.
Tags
None
Referenced Files
F6046584: D10740.id35878.diff
Sun, Apr 20, 5:04 AM
Unknown Object (File)
Sat, Apr 19, 7:30 AM
Unknown Object (File)
Sat, Apr 19, 6:37 AM
Unknown Object (File)
Fri, Apr 18, 7:37 AM
Unknown Object (File)
Wed, Apr 9, 12:42 AM
Unknown Object (File)
Fri, Apr 4, 10:21 AM
Unknown Object (File)
Wed, Mar 26, 3:50 PM
Unknown Object (File)
Feb 23 2025, 8:17 PM
View All 69 Files
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMM3c2f5064fc79: [native] rename login -> logIn where appropriate
Summary

login is not a verb, so we should use logIn or log_in instead when describing the action

Test Plan

successfully built the app for simulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
4 lines
8 lines
_generated/
native_rust_library/
src/
20 lines
schema/
4 lines

Diff 35882

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/native_rust_library/src/lib.rs

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/schema/CommRustModuleSchema.js

Loading...