[native][web] Clear user specific data on identity actions
ClosedPublic
Actions

Authored by inka on Jan 29 2024, 3:34 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM63edbf4aa371: [native][web] Clear user specific data on identity actions

Summary

issue: ENG-6424
Login will be handled once it's implemented. It's being tracked in ENG-6598. In this diff I want to handle logout, delete account and register identity actions
I will remove logic from specific reducers in next diffs
I had to change the dafault state on web - I need the navInfo to be correct. This is how we do it on native. I don't think it's the best, but at least the data is of correct shape, and again - this is how we do it on native, so I think we can use this for now

Test Plan

Tested that it is possible to log out and back in, and no errors show up. Tested that the data is cleared on logout success

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 29 2024, 3:34 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 3:34 AM

inka added a parent revision: D10845: [web][native] Create lists of fields that are not to be removed on identity actions.Jan 29 2024, 3:36 AM

inka edited the summary of this revision. (Show Details)Jan 29 2024, 3:46 AM

Harbormaster completed remote builds in B26243: Diff 36245.Jan 29 2024, 3:53 AM

inka requested review of this revision.Jan 29 2024, 3:53 AM

It might be better to for navInfo do the same thing we do for actualizedCalendarQuery - in specific reducer use defaultCalendarQuery(getConfig().platformDetails.platform).

inka mentioned this in D10868: [lib] Remove logout / delete account / identity login logic from specific reducers.Jan 29 2024, 5:44 AM

inka added a child revision: D10868: [lib] Remove logout / delete account / identity login logic from specific reducers.Jan 29 2024, 6:00 AM

It might be better to for navInfo do the same thing we do for actualizedCalendarQuery - in specific reducer use defaultCalendarQuery(getConfig().platformDetails.platform).

Makes sense

This revision is now accepted and ready to land.Jan 30 2024, 9:01 AM

ashoat mentioned this in D10784: [native][web] migrate keyservers to SQLite.Jan 30 2024, 12:12 PM

Make reduceBaseNavInfo set the default date ranges

michal accepted this revision.Jan 31 2024, 10:30 AM

Harbormaster completed remote builds in B26354: Diff 36425.Jan 31 2024, 10:43 AM

Closed by commit rCOMM63edbf4aa371: [native][web] Clear user specific data on identity actions (authored by inka). · Explain WhyFeb 1 2024, 3:23 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM63edbf4aa371: [native][web] Clear user specific data on identity actions.

inka mentioned this in rCOMM925785ebd455: [lib] Remove logout / delete account / identity login logic from specific….

inka mentioned this in D11394: [lib][web][native] Handle idnentity login in reducers.Mar 27 2024, 4:12 AM

inka mentioned this in rCOMM362fadd02e70: [lib][web][native] Handle idnentity login in reducers.Mar 29 2024, 4:58 AM