identity login logic from specific reducers
ClosedPublic
Actions

Authored by inka on Jan 29 2024, 5:44 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM925785ebd455: [lib] Remove logout / delete account / identity login logic from specific…

Summary

issue: ENG-6424
Removing logic handling logout and delete account actions from specific reducers, because now we are removing all this state in one place using resetUserSpecificStateOnIdentityActions (see D10860)
I didn't remove logic from the following reducers:

reduceCurrentUserInfo, because these actions set a new currentUserInfo
reduceReportStore, because we set some special values to enabledReports on those actions
reduceKeyserverStore, baceuse we have to handle Ashoat's keyserver in a special way

Test Plan

Tested that it's possible to log out and back in, and no errors show up. Tested that on logout success state is still cleared

Diff Detail

Repository

rCOMM Comm

Branch

inka/login_reducers

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 29 2024, 5:44 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 5:44 AM

inka added a parent revision: D10860: [native][web] Clear user specific data on identity actions.Jan 29 2024, 6:00 AM

Harbormaster completed remote builds in B26253: Diff 36264.Jan 29 2024, 6:03 AM

inka requested review of this revision.Jan 29 2024, 6:03 AM

inka added inline comments.Jan 29 2024, 6:08 AM

lib/reducers/data-loaded-reducer.js
29	We want to keep this, because we don't want the user to have to wait to see the logout screen
lib/reducers/policies-reducer.js
49	We want to keep this, because we are setting `dataLoaded` to false on `.started`, and we don't want to display policies modals on the logout screen
lib/reducers/theme-reducer.js
35	We want to keep this, because we are setting dataLoaded to false on .started, so we want to also reset the theme

inka added a child revision: D10869: [web] Remove logout / delete account / identity login logic from specific reducers.Jan 29 2024, 6:43 AM

ashoat added inline comments.Jan 29 2024, 11:24 AM

lib/reducers/theme-reducer.js
35	Hmmm... wouldn't that lead to some weird flickering on logout? When the user presses the logout button, it will flicker from the user-selected theme to the default theme, while the logout animation is running. Why not remove this and let it happen on `logOutActionTypes.success`, to avoid the flickering? cc @ginsu