Details
- Sent multimedia messages - checked Reports service - reports had user ID set
- Triggered a crash with CSAT unset - user ID was unknown in generated report
- Sent a message with CSAT set - user ID was set in generated report
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/crash.react.js | ||
|---|---|---|
| 163 | This works here, but I'm wondering if calling commCoreModule.getCommServicesAuthMetadata() directly from here wouldn't be better in case of a crash | |
I wonder if there's a more generic way we could handle this... I could imagine defining this similar to keyserver actions, where "Comm service actions" are defined as functions that take functions as input. The inner function would be something like callAuthenticatedCommService, and it would allow the "Comm service action" to abstract away the details of authentication. Then we would have a hook (eg. useCommServiceCall) that takes the "Comm service action" function as input, and binds in the callAuthenticatedCommService function.
I've proposed something less generic but also less complicated in https://phab.comm.dev/D10912#316146
| native/crash.react.js | ||
|---|---|---|
| 163 | If this component is rendered below the provider, it should work the same. On the other hand, we can't be sure what caused the crash, which means that reducing the number of layers we're using here is beneficial. Up to you. | |
| native/crash.react.js | ||
|---|---|---|
| 163 |
Agree with this. We should keep things simple here | |
- Used hook abstraction as proposed
- Used direct commCoreModule call in crash component