Page MenuHomePhabricator
Differential D10975

[lib] Add `shouldIncludeSpecialRoleFieldInRoles` to `RawThreadInfoOptions`
ClosedPublic
Actions

Authored by atul on Feb 6 2024, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 10:22 AM
Unknown Object (File)
Sun, Mar 2, 3:24 PM
Unknown Object (File)
Fri, Feb 28, 4:29 AM
Unknown Object (File)
Wed, Feb 26, 3:57 PM
Unknown Object (File)
Mon, Feb 24, 6:25 AM
Unknown Object (File)
Feb 20 2025, 4:37 AM
Unknown Object (File)
Feb 20 2025, 4:26 AM
Unknown Object (File)
Feb 20 2025, 4:04 AM
View All 87 Files
Subscribers
None

Details

Reviewers
ginsu
tomek
Commits
rCOMMf754b7402820: [lib] Add `shouldIncludeSpecialRoleFieldInRoles` to `RawThreadInfoOptions`
Summary

Setting the minimum code version for all platforms to FUTURE_CODE_VERSION for the timebeing.

Depends on D10971

Test Plan

Will be tested implicitly by subsequent diffs in stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
11 lines
lib/
shared/
1 line

Diff 36862

View Options

keyserver/src/fetchers/thread-fetchers.js

locals {
mariadb_database_name = local.local_with_default_environment_vars.COMM_DATABASE_DATABASE
mariadb_username = local.local_with_default_environment_vars.COMM_DATABASE_USER
mariadb_password = local.local_with_default_environment_vars.COMM_DATABASE_PASSWORD
mariadb_port = jsondecode(local.local_with_default_environment_vars.COMM_DATABASE_PORT)
}
# MariaDB Security Group # MariaDB Security Group
resource "aws_security_group" "keyserver_mariadb_security_group" { resource "aws_security_group" "keyserver_mariadb_security_group" {
name = "keyserver-mariadb-sg" name = "keyserver-mariadb-sg"
description = "Allow inbound traffic on port 3307 and all outbound traffic" description = "Allow inbound traffic on port 3307 and all outbound traffic"
vpc_id = local.vpc_id vpc_id = local.vpc_id
# Inbound rules # Inbound rules
ingress { ingress {
from_port = 3307 from_port = local.mariadb_port
to_port = 3307 to_port = local.mariadb_port
protocol = "tcp" protocol = "tcp"
security_groups = [aws_security_group.keyserver_service.id] security_groups = [aws_security_group.keyserver_service.id]
} }
ingress { ingress {
from_port = 3307 from_port = local.mariadb_port
to_port = 3307 to_port = local.mariadb_port
protocol = "tcp" protocol = "tcp"
cidr_blocks = ["${var.allowed_ip}/32"] cidr_blocks = ["${var.allowed_ip}/32"]
} }
# Outbound rules # Outbound rules
egress { egress {
from_port = 0 from_port = 0
to_port = 0 to_port = 0
Show All 9 Linesresource "aws_db_instance" "mariadb" {
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
instance_class = "db.m6g.large" instance_class = "db.m6g.large"
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = var.mariadb_username username = local.mariadb_username
password = var.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = 3307 port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Linesresource "aws_db_parameter_group" "mariadb_parameter_group" {
} }
} }
resource "null_resource" "create_comm_database" { resource "null_resource" "create_comm_database" {
depends_on = [aws_db_instance.mariadb, aws_security_group.keyserver_mariadb_security_group] depends_on = [aws_db_instance.mariadb, aws_security_group.keyserver_mariadb_security_group]
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
mysql --user=${var.mariadb_username} \ mysql --user=${local.mariadb_username} \
--port=3307 \ --port=${local.mariadb_port} \
--host=${aws_db_instance.mariadb.address} \ --host=${aws_db_instance.mariadb.address} \
--execute="CREATE DATABASE IF NOT EXISTS comm;" \ --execute="CREATE DATABASE IF NOT EXISTS ${local.mariadb_database_name};" \
--password=${var.mariadb_password} --password=${local.mariadb_password}
EOT EOT
} }
} }
View Options

lib/shared/thread-utils.js

locals {
mariadb_database_name = local.local_with_default_environment_vars.COMM_DATABASE_DATABASE
mariadb_username = local.local_with_default_environment_vars.COMM_DATABASE_USER
mariadb_password = local.local_with_default_environment_vars.COMM_DATABASE_PASSWORD
mariadb_port = jsondecode(local.local_with_default_environment_vars.COMM_DATABASE_PORT)
}
# MariaDB Security Group # MariaDB Security Group
resource "aws_security_group" "keyserver_mariadb_security_group" { resource "aws_security_group" "keyserver_mariadb_security_group" {
name = "keyserver-mariadb-sg" name = "keyserver-mariadb-sg"
description = "Allow inbound traffic on port 3307 and all outbound traffic" description = "Allow inbound traffic on port 3307 and all outbound traffic"
vpc_id = local.vpc_id vpc_id = local.vpc_id
# Inbound rules # Inbound rules
ingress { ingress {
from_port = 3307 from_port = local.mariadb_port
to_port = 3307 to_port = local.mariadb_port
protocol = "tcp" protocol = "tcp"
security_groups = [aws_security_group.keyserver_service.id] security_groups = [aws_security_group.keyserver_service.id]
} }
ingress { ingress {
from_port = 3307 from_port = local.mariadb_port
to_port = 3307 to_port = local.mariadb_port
protocol = "tcp" protocol = "tcp"
cidr_blocks = ["${var.allowed_ip}/32"] cidr_blocks = ["${var.allowed_ip}/32"]
} }
# Outbound rules # Outbound rules
egress { egress {
from_port = 0 from_port = 0
to_port = 0 to_port = 0
Show All 9 Linesresource "aws_db_instance" "mariadb" {
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
instance_class = "db.m6g.large" instance_class = "db.m6g.large"
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = var.mariadb_username username = local.mariadb_username
password = var.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = 3307 port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Linesresource "aws_db_parameter_group" "mariadb_parameter_group" {
} }
} }
resource "null_resource" "create_comm_database" { resource "null_resource" "create_comm_database" {
depends_on = [aws_db_instance.mariadb, aws_security_group.keyserver_mariadb_security_group] depends_on = [aws_db_instance.mariadb, aws_security_group.keyserver_mariadb_security_group]
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
mysql --user=${var.mariadb_username} \ mysql --user=${local.mariadb_username} \
--port=3307 \ --port=${local.mariadb_port} \
--host=${aws_db_instance.mariadb.address} \ --host=${aws_db_instance.mariadb.address} \
--execute="CREATE DATABASE IF NOT EXISTS comm;" \ --execute="CREATE DATABASE IF NOT EXISTS ${local.mariadb_database_name};" \
--password=${var.mariadb_password} --password=${local.mariadb_password}
EOT EOT
} }
} }