Page MenuHomePhabricator

[lib] Update minimally-encoded-thread-permissions.test.js to include specialRole field
ClosedPublic

Authored by atul on Nov 30 2023, 1:13 PM.
Tags
None
Referenced Files
F3516927: D10111.id36963.diff
Sun, Dec 22, 3:50 PM
F3515904: D10111.id36958.diff
Sun, Dec 22, 10:58 AM
Unknown Object (File)
Sat, Dec 21, 2:24 PM
Unknown Object (File)
Wed, Dec 18, 1:07 AM
Unknown Object (File)
Wed, Dec 18, 1:07 AM
Unknown Object (File)
Wed, Dec 18, 1:07 AM
Unknown Object (File)
Wed, Dec 18, 1:07 AM
Unknown Object (File)
Wed, Dec 18, 1:06 AM
Subscribers

Details

Summary

There are some places in the codebase that we hardcode isDefault. Here, we'll want to introduce the specialRole field alongside, so when we deprecate isDefault, no additional changes will be needed. Some are important (like one instance in thread-utils.js and the instance in role-creator.js where we set up initial roles for threads), and others are just test data. Nonetheless, I thought I may as well update all of them for consistency.

Part of ENG-5993

This diff handles minimally-encoded-thread-permissions.test.js

Depends on D10110

Test Plan

Ran yarn workspace lib test to make sure unit tests still passed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan held this revision as a draft.
rohan published this revision for review.Nov 30 2023, 1:33 PM

Use constant for specialRole

This revision is now accepted and ready to land.Dec 1 2023, 1:55 PM
atul edited reviewers, added: rohan; removed: atul.
This revision now requires review to proceed.Feb 5 2024, 12:39 PM
This revision is now accepted and ready to land.Feb 6 2024, 12:45 AM