Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMMaf6fabf79679: [keyserver] Update role-creator to include specialRole field

Summary

There are some places in the codebase that we hardcode isDefault. Here, we'll want to introduce the specialRole field alongside, so when we deprecate isDefault, no additional changes will be needed. Some are important (like one instance in thread-utils.js and the instance in role-creator.js where we set up initial roles for threads), and others are just test data. Nonetheless, I thought I may as well update all of them for consistency.

Part of ENG-5993

This diff handles role-creator.js

Depends on D10107

Test Plan

Right now, just flow to make sure we didn't violate the type. Further testing can be done once isDefault is removed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Nov 30 2023, 1:11 PM

rohan held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 30 2023, 1:11 PM

rohan added a child revision: D10109: [lib] Update thread-utils to include specialRole field.Nov 30 2023, 1:12 PM

rohan edited the test plan for this revision. (Show Details)Nov 30 2023, 1:24 PM

rohan published this revision for review.Nov 30 2023, 1:33 PM

Harbormaster failed remote builds in B24654: Diff 34067!Nov 30 2023, 1:55 PM

Harbormaster completed remote builds in B24654: Diff 34067.Nov 30 2023, 4:23 PM

tomek accepted this revision.Dec 1 2023, 7:55 AM

This revision is now accepted and ready to land.Dec 1 2023, 7:55 AM

atul commandeered this revision.Feb 5 2024, 12:38 PM

atul edited reviewers, added: rohan; removed: atul.

update

lib/shared/thread-utils.js
767 ↗	(On Diff #36886)	This should not have been staged, this was from testing another diff. Will update

unstage extraneous code

This should be safe to land on its own:

createInitialRolesForNewThread() is only called by createThread() in thread-creator
The only fields accessed are newRoles.default.id and newRoles.creator.id, so nothing changes here