Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM09b4194803d4: [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to…

Summary

We want to update code that fetches from threads or roles to appropriately also fetch roles.special_role so we can include it in the return object. For now, I will leave in the r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default since I'm intermediately leaving in the isDefault property in RoleInfo. Towards the end of the stack, I will remove this check alongside the property as mentioned in the Linear task.

Part of ENG-5993

This diff handles thread.fetchers.js

Depends on D10106

Test Plan

Ran the query before and after to confirm the results are identical, except with the new special_role field

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Nov 30 2023, 1:05 PM

rohan held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 30 2023, 1:05 PM

rohan added a child revision: D10108: [keyserver] Update role-creator to include specialRole field.Nov 30 2023, 1:11 PM

rohan edited the test plan for this revision. (Show Details)Nov 30 2023, 1:23 PM

Harbormaster completed remote builds in B24653: Diff 34066.Nov 30 2023, 1:28 PM

rohan published this revision for review.Nov 30 2023, 1:33 PM

tomek accepted this revision.Dec 1 2023, 7:54 AM

This revision is now accepted and ready to land.Dec 1 2023, 7:54 AM

atul commandeered this revision.Feb 5 2024, 12:36 PM

atul edited reviewers, added: rohan; removed: atul.

update

atul requested review of this revision.Feb 6 2024, 11:55 AM

atul retitled this revision from [keyserver] Update thread-fetchers to fetch special_role to [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to fetch special_role.

fix query

atul added inline comments.Feb 6 2024, 12:02 PM

keyserver/src/fetchers/thread-fetchers.js
237 ↗	(On Diff #36727)	Explicitly annotated to handle `flow` limitation described here: https://linear.app/comm/issue/ENG-6596/investigate-why-flow-didnt-detect-issue-with-creatependingthread Otherwise I could put in whatever:
lib/types/thread-types.js
160 ↗	(On Diff #36727)	NOTE: Updated `ServerThreadInfo` here to have each role be `ServerLegacyRoleInfo` instead of `ClientLegacyRoleInfo`. Will handle stripping out/keeping of `specialRole` field in `rawThreadInfoFromServerThreadInfo` based on `codeVersion` checks.