Page MenuHomePhabricator
Differential D10971

[lib] Remove support for `ServerThreadInfo` from `useKeyserverAdmin`
ClosedPublic
Actions

Authored by atul on Feb 6 2024, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 3:40 PM
Unknown Object (File)
Mon, Mar 17, 6:29 AM
Unknown Object (File)
Sun, Mar 16, 9:11 AM
Unknown Object (File)
Thu, Mar 13, 1:32 AM
Unknown Object (File)
Mon, Mar 10, 5:03 PM
Unknown Object (File)
Feb 28 2025, 3:02 AM
Unknown Object (File)
Feb 20 2025, 4:37 AM
Unknown Object (File)
Feb 20 2025, 4:26 AM
View All 73 Files
Subscribers
None

Details

Reviewers
ginsu
tomek
Commits
rCOMMb643636cd299: [lib] Remove support for `ServerThreadInfo` from `useKeyserverAdmin`
Summary

In D10107 I encountered a scenario where flow wasn't able to type check ServerLegacyRoleInfo as part of a ServerThreadInfo being constructed.

To be safe, I decided to look at all instances of ServerThreadInfo and fetchServerThreadInfos() in the codebase to double check for similar issues.

I didn't find any, but noticed that useKeyserverAdmin accepted ServerThreadInfo which seems strange. Looks like it was added when useKeyserverAdmin was getKeyserverAdmin. Regardless, it's no longer necessary so I removed it.

Depends on D10107

Test Plan

flow + seeing that the hook is only ever used by the CommunityPill react component which should never encounter a ServerThreadInfo.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines

Diff 36861

View Options

lib/shared/user-utils.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines