Page MenuHomePhabricator
Differential D10971

[lib] Remove support for `ServerThreadInfo` from `useKeyserverAdmin`
ClosedPublic
Actions

Authored by atul on Feb 6 2024, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 9:59 AM
Unknown Object (File)
Thu, Apr 17, 3:29 AM
Unknown Object (File)
Wed, Apr 16, 10:36 PM
Unknown Object (File)
Wed, Apr 16, 1:30 AM
Unknown Object (File)
Wed, Apr 9, 11:57 AM
Unknown Object (File)
Mar 18 2025, 3:40 PM
Unknown Object (File)
Mar 17 2025, 6:29 AM
Unknown Object (File)
Mar 16 2025, 9:11 AM
View All 78 Files
Subscribers
None

Details

Reviewers
ginsu
tomek
Commits
rCOMMb643636cd299: [lib] Remove support for `ServerThreadInfo` from `useKeyserverAdmin`
Summary

In D10107 I encountered a scenario where flow wasn't able to type check ServerLegacyRoleInfo as part of a ServerThreadInfo being constructed.

To be safe, I decided to look at all instances of ServerThreadInfo and fetchServerThreadInfos() in the codebase to double check for similar issues.

I didn't find any, but noticed that useKeyserverAdmin accepted ServerThreadInfo which seems strange. Looks like it was added when useKeyserverAdmin was getKeyserverAdmin. Regardless, it's no longer necessary so I removed it.

Depends on D10107

Test Plan

flow + seeing that the hook is only ever used by the CommunityPill react component which should never encounter a ServerThreadInfo.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines

Diff 36861

View Options

lib/shared/user-utils.js

Show First 20 Lines • Show All 289 Lines • ▼ Show 20 Lines if (
typeof document !== 'undefined' && typeof document !== 'undefined' &&
document && document &&
'hasFocus' in document && 'hasFocus' in document &&
document.hasFocus() && document.hasFocus() &&
!state.navInfo.pendingThread && !state.navInfo.pendingThread &&
state.threadStore.threadInfos[activeThread].currentUser.unread state.threadStore.threadInfos[activeThread].currentUser.unread
) { ) {
// Makes sure a currently focused thread is never unread // Makes sure a currently focused thread is never unread
const activeThreadInfo = state.threadStore.threadInfos[activeThread];
// TODO (atul): Try to get rid of this ridiculous branching.
if (activeThreadInfo.minimallyEncoded) {
updateActiveThreadOps.push({ updateActiveThreadOps.push({
type: 'replace', type: 'replace',
payload: { payload: {
id: activeThread, id: activeThread,
threadInfo: { threadInfo: {
...state.threadStore.threadInfos[activeThread], ...activeThreadInfo,
currentUser: { currentUser: {
...state.threadStore.threadInfos[activeThread].currentUser, ...activeThreadInfo.currentUser,
unread: false, unread: false,
}, },
}, },
}, },
}); });
} else {
updateActiveThreadOps.push({
type: 'replace',
payload: {
id: activeThread,
threadInfo: {
...activeThreadInfo,
currentUser: {
...activeThreadInfo.currentUser,
unread: false,
},
},
},
});
}
} }
const oldActiveThread = activeThreadSelector(oldState); const oldActiveThread = activeThreadSelector(oldState);
if ( if (
activeThread && activeThread &&
oldActiveThread !== activeThread && oldActiveThread !== activeThread &&
state.messageStore.threads[activeThread] state.messageStore.threads[activeThread]
) { ) {
Show All 37 Lines