Page MenuHomePhabricator

[lib] Remove support for `ServerThreadInfo` from `useKeyserverAdmin`
ClosedPublic

Authored by atul on Feb 6 2024, 12:21 PM.
Tags
None
Referenced Files
F3371079: D10971.diff
Tue, Nov 26, 4:27 AM
Unknown Object (File)
Oct 25 2024, 6:01 PM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:47 AM
Unknown Object (File)
Aug 29 2024, 10:50 AM
Unknown Object (File)
Aug 29 2024, 10:50 AM
Subscribers
None

Details

Summary

In D10107 I encountered a scenario where flow wasn't able to type check ServerLegacyRoleInfo as part of a ServerThreadInfo being constructed.

To be safe, I decided to look at all instances of ServerThreadInfo and fetchServerThreadInfos() in the codebase to double check for similar issues.

I didn't find any, but noticed that useKeyserverAdmin accepted ServerThreadInfo which seems strange. Looks like it was added when useKeyserverAdmin was getKeyserverAdmin. Regardless, it's no longer necessary so I removed it.


Depends on D10107

Test Plan

flow + seeing that the hook is only ever used by the CommunityPill react component which should never encounter a ServerThreadInfo.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage