Details

Reviewers

marcin
varun
tomek

Commits

rCOMM65369defbe28: [native][web] implementing uploading one-time keys in `IdentityServiceClient`

Summary

Call RPC to upload keys to Identity.

Depends on D11108

Test Plan

Call this method and check in staging DDB that one-time key was uploaded.

await identityClient.uploadOneTimeKeys({
        contentOneTimeKeys: ['test1'],
        notificationsOneTimeKeys: ['test2'],
      })

Screenshot 2024-02-19 at 13.08.59.png (1×1 px, 283 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 19 2024, 4:12 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 4:12 PM

kamil edited the test plan for this revision. (Show Details)Feb 19 2024, 4:13 PM

Harbormaster completed remote builds in B26969: Diff 37328.Feb 19 2024, 4:27 PM

kamil added a child revision: D11110: [web] implementing publishing prekeys to Identity.Feb 19 2024, 4:28 PM

kamil published this revision for review.Feb 19 2024, 5:36 PM

Is marking as published handled separately?

tomek accepted this revision.Feb 21 2024, 9:57 AM

This revision is now accepted and ready to land.Feb 21 2024, 9:57 AM

In D11109#321001, @ashoat wrote:

Is marking as published handled separately?

Yes, in D11109

I think you linked the wrong diff (you linked this one)

In D11109#321883, @ashoat wrote:

I think you linked the wrong diff (you linked this one)

ahh right - D11119

Closed by commit rCOMM65369defbe28: [native][web] implementing uploading one-time keys in `IdentityServiceClient`. · Explain WhyFeb 23 2024, 9:32 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM65369defbe28: [native][web] implementing uploading one-time keys in `IdentityServiceClient`.

[native][web] implementing uploading one-time keys in `IdentityServiceClient`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 37486

lib/types/crypto-types.js

lib/types/identity-service-types.js

native/identity-service/identity-service-context-provider.react.js

web/grpc/identity-service-client-wrapper.js

[native][web] implementing uploading one-time keys in `IdentityServiceClient`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37486

lib/types/crypto-types.js

lib/types/identity-service-types.js

native/identity-service/identity-service-context-provider.react.js

web/grpc/identity-service-client-wrapper.js

[native][web] implementing uploading one-time keys in `IdentityServiceClient`
ClosedPublic
Actions

Revision Contents
Changeset List