[native] implementing getting inbound user keys in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 3:55 PM.

Details

Reviewers

marcin
varun
tomek

Commits

rCOMM7e6bbead1522: [native] implementing getting inbound user keys in `IdentityServiceClient`

Summary

Call RPC to get the keys of all devices of a given user.

Depends on D11107

Test Plan

Call method and log result

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 19 2024, 3:55 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 3:55 PM

Harbormaster completed remote builds in B26966: Diff 37325.Feb 19 2024, 4:10 PM

kamil added a child revision: D11109: [native][web] implementing uploading one-time keys in `IdentityServiceClient`.Feb 19 2024, 4:12 PM

kamil published this revision for review.Feb 19 2024, 5:35 PM

kamil added inline comments.

native/identity-service/identity-service-context-provider.react.js
257 ↗	(On Diff #37325)	looks like we can use any device so using the first one

ashoat added a subscriber: bartek.Feb 20 2024, 3:43 AM

ashoat added inline comments.

native/identity-service/identity-service-context-provider.react.js
257 ↗	(On Diff #37325)	I think we're working on updating the API here to be less confusing. cc @bartek

tomek accepted this revision.Feb 21 2024, 9:55 AM

tomek added inline comments.

native/identity-service/identity-service-context-provider.react.js
260–261 ↗	(On Diff #37325)	Can we validate these?

This revision is now accepted and ready to land.Feb 21 2024, 9:55 AM

kamil mentioned this in D11106: [crypto] unify key types and introduce type for Inbound Keys.Feb 22 2024, 3:58 PM

improve validation

Harbormaster completed remote builds in B27069: Diff 37447.Feb 22 2024, 4:37 PM

Closed by commit rCOMM7e6bbead1522: [native] implementing getting inbound user keys in `IdentityServiceClient`. · Explain WhyFeb 23 2024, 9:32 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7e6bbead1522: [native] implementing getting inbound user keys in `IdentityServiceClient`.

Revision Contents
Changeset List

Path

Size

lib/

types/

identity-service-types.js

2 lines

native/

identity-service/

identity-service-context-provider.react.js

70 lines

Diff 37485

View Options

lib/types/identity-service-types.js