Page MenuHomePhabricator
Differential D11108

[native] implementing getting inbound user keys in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 7:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 3:26 PM
Unknown Object (File)
Thu, Apr 17, 2:23 PM
Unknown Object (File)
Thu, Apr 17, 5:26 AM
Unknown Object (File)
Wed, Apr 16, 11:11 PM
Unknown Object (File)
Wed, Apr 16, 3:35 PM
Unknown Object (File)
Wed, Apr 16, 3:34 PM
Unknown Object (File)
Sat, Apr 12, 5:21 PM
Unknown Object (File)
Mar 14 2025, 5:01 AM
View All Files
Subscribers
ashoat
bartek

Details

Reviewers
marcin
varun
tomek
Commits
rCOMM7e6bbead1522: [native] implementing getting inbound user keys in `IdentityServiceClient`
Summary

Call RPC to get the keys of all devices of a given user.

Depends on D11107

Test Plan

Call method and log result

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Feb 19 2024, 7:55 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 7:55 AM
Harbormaster completed remote builds in B26966: Diff 37325.Feb 19 2024, 8:10 AM
kamil added a child revision: D11109: [native][web] implementing uploading one-time keys in `IdentityServiceClient`.Feb 19 2024, 8:12 AM
kamil published this revision for review.Feb 19 2024, 9:35 AM
kamil added inline comments.
native/identity-service/identity-service-context-provider.react.js
257 ↗(On Diff #37325)

looks like we can use any device so using the first one

ashoat added a subscriber: bartek.Feb 19 2024, 7:43 PM
ashoat added inline comments.
native/identity-service/identity-service-context-provider.react.js
257 ↗(On Diff #37325)

I think we're working on updating the API here to be less confusing. cc @bartek

tomek accepted this revision.Feb 21 2024, 1:55 AM
tomek added inline comments.
native/identity-service/identity-service-context-provider.react.js
260–261 ↗(On Diff #37325)

Can we validate these?

This revision is now accepted and ready to land.Feb 21 2024, 1:55 AM
kamil mentioned this in D11106: [crypto] unify key types and introduce type for Inbound Keys.Feb 22 2024, 7:58 AM
kamil updated this revision to Diff 37447.Feb 22 2024, 8:03 AM

improve validation

Harbormaster completed remote builds in B27069: Diff 37447.Feb 22 2024, 8:37 AM
Closed by commit rCOMM7e6bbead1522: [native] implementing getting inbound user keys in `IdentityServiceClient` (authored by kamil). · Explain WhyFeb 23 2024, 1:32 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7e6bbead1522: [native] implementing getting inbound user keys in `IdentityServiceClient`.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
identity-service/
70 lines

Diff 37485

View Options

lib/types/identity-service-types.js

#pragma once #pragma once
#include "../CryptoTools/Persist.h" #include "../CryptoTools/Persist.h"
#include "entities/CommunityInfo.h" #include "entities/CommunityInfo.h"
#include "entities/Draft.h" #include "entities/Draft.h"
#include "entities/IntegrityThreadHash.h"
#include "entities/KeyserverInfo.h" #include "entities/KeyserverInfo.h"
#include "entities/Message.h" #include "entities/Message.h"
#include "entities/MessageStoreThread.h" #include "entities/MessageStoreThread.h"
#include "entities/MessageToDevice.h" #include "entities/MessageToDevice.h"
#include "entities/OlmPersistAccount.h" #include "entities/OlmPersistAccount.h"
#include "entities/OlmPersistSession.h" #include "entities/OlmPersistSession.h"
#include "entities/PersistItem.h" #include "entities/PersistItem.h"
#include "entities/Report.h" #include "entities/Report.h"
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Linespublic:
virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0; virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;
virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0; virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;
virtual void removeAllKeyservers() const = 0; virtual void removeAllKeyservers() const = 0;
virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0; virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;
virtual void replaceCommunity(const CommunityInfo &community_info) const = 0; virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;
virtual void removeCommunities(const std::vector<std::string> &ids) const = 0; virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;
virtual void removeAllCommunities() const = 0; virtual void removeAllCommunities() const = 0;
virtual std::vector<CommunityInfo> getAllCommunities() const = 0; virtual std::vector<CommunityInfo> getAllCommunities() const = 0;
virtual void replaceIntegrityThreadHashes(
const std::vector<IntegrityThreadHash> &thread_hashes) const = 0;
virtual void
removeIntegrityThreadHashes(const std::vector<std::string> &ids) const = 0;
virtual void removeAllIntegrityThreadHashes() const = 0;
virtual std::vector<IntegrityThreadHash>
getAllIntegrityThreadHashes() const = 0;
virtual void beginTransaction() const = 0; virtual void beginTransaction() const = 0;
virtual void commitTransaction() const = 0; virtual void commitTransaction() const = 0;
virtual void rollbackTransaction() const = 0; virtual void rollbackTransaction() const = 0;
virtual int getContentAccountID() const = 0; virtual int getContentAccountID() const = 0;
virtual int getNotifsAccountID() const = 0; virtual int getNotifsAccountID() const = 0;
virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0; virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;
virtual std::optional<std::string> virtual std::optional<std::string>
getOlmPersistAccountData(int accountID) const = 0; getOlmPersistAccountData(int accountID) const = 0;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines
View Options

native/identity-service/identity-service-context-provider.react.js

#pragma once #pragma once
#include "../CryptoTools/Persist.h" #include "../CryptoTools/Persist.h"
#include "entities/CommunityInfo.h" #include "entities/CommunityInfo.h"
#include "entities/Draft.h" #include "entities/Draft.h"
#include "entities/IntegrityThreadHash.h"
#include "entities/KeyserverInfo.h" #include "entities/KeyserverInfo.h"
#include "entities/Message.h" #include "entities/Message.h"
#include "entities/MessageStoreThread.h" #include "entities/MessageStoreThread.h"
#include "entities/MessageToDevice.h" #include "entities/MessageToDevice.h"
#include "entities/OlmPersistAccount.h" #include "entities/OlmPersistAccount.h"
#include "entities/OlmPersistSession.h" #include "entities/OlmPersistSession.h"
#include "entities/PersistItem.h" #include "entities/PersistItem.h"
#include "entities/Report.h" #include "entities/Report.h"
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Linespublic:
virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0; virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;
virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0; virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;
virtual void removeAllKeyservers() const = 0; virtual void removeAllKeyservers() const = 0;
virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0; virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;
virtual void replaceCommunity(const CommunityInfo &community_info) const = 0; virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;
virtual void removeCommunities(const std::vector<std::string> &ids) const = 0; virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;
virtual void removeAllCommunities() const = 0; virtual void removeAllCommunities() const = 0;
virtual std::vector<CommunityInfo> getAllCommunities() const = 0; virtual std::vector<CommunityInfo> getAllCommunities() const = 0;
virtual void replaceIntegrityThreadHashes(
const std::vector<IntegrityThreadHash> &thread_hashes) const = 0;
virtual void
removeIntegrityThreadHashes(const std::vector<std::string> &ids) const = 0;
virtual void removeAllIntegrityThreadHashes() const = 0;
virtual std::vector<IntegrityThreadHash>
getAllIntegrityThreadHashes() const = 0;
virtual void beginTransaction() const = 0; virtual void beginTransaction() const = 0;
virtual void commitTransaction() const = 0; virtual void commitTransaction() const = 0;
virtual void rollbackTransaction() const = 0; virtual void rollbackTransaction() const = 0;
virtual int getContentAccountID() const = 0; virtual int getContentAccountID() const = 0;
virtual int getNotifsAccountID() const = 0; virtual int getNotifsAccountID() const = 0;
virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0; virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;
virtual std::optional<std::string> virtual std::optional<std::string>
getOlmPersistAccountData(int accountID) const = 0; getOlmPersistAccountData(int accountID) const = 0;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines