[crypto] implement prekey rotation in `OlmAPI`
ClosedPublic
Actions

Authored by kamil on Feb 23 2024, 2:35 AM.

Details

Reviewers

Commits

Summary

Shared code with prekeys rotation.

Web part should match native C++ version implemented here.

This code could be vulnerable to multiple promises modyfing olm account but fixing this is tracked in ENG-6768.

For now matching code implemented in native - but we should mark prekeys as published before uploading as described and tracked here. (cc. @varun)

Depends on D11120

Test Plan

Modify shouldRotatePrekey method to return true and check if it works.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kamil held this revision as a draft.

kamil added inline comments.

native/components/prekeys-handler.react.js
1 ↗	(On Diff #37488)	Now with `OlmAPI` we can move it to the lib
web/crypto/olm-api.js
118 ↗	(On Diff #37488)	on native notif rotation is also not implemented

kamil published this revision for review.Feb 23 2024, 4:22 AM

native/root.react.js
339 ↗	(On Diff #37488)	Did the order need to be changed?

tomek added inline comments.

lib/components/prekeys-handler.react.js
35 ↗	(On Diff #37488)	Are we sure we want to rotate the keys after each context change? Looking at the context code, it seems that yes.
web/crypto/olm-api.js
105–116 ↗	(On Diff #37488)	We should move this logic to a deeper level, just like we have it on native - it will be handled by https://linear.app/comm/issue/ENG-6768/migrate-validateanduploadprekeys-to-shared-worker