This code is web specific - so I think it's butter to implement it this way than adding this to IdentityServiceClient and mocking on native.
On native this method is used only from C++ level and is not exposed to JS.
Depends on D11109
Details
Details
Call this method and check in staging DDB that prekeys were updated.
await publishPrekeysToIdentity({
contentPrekey: 'test0',
contentPrekeySignature: 'test1',
notifPrekey: 'test2',
notifPrekeySignature: 'test3',
}, identityClient);
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This code is web specific - so I think it's butter to implement it this way than adding this to IdentityServiceClient and mocking on native.
I think there's a benefit to having everything in one place. It looks like registerUser only works on native, so we're already taking this approach in IdentityServiceClient.
On native this method is used only from C++ level and is not exposed to JS.
Can you explain why we have a single call to handle both prekey rotation and publishing on native, but separate calls on web? Ideally we would have a unified approach across platforms.
Separately, can you clarify if marking as published is handled separately?
Comment Actions
I think that keeping the solution as symmetrical as possible is a good idea. In this case, we should probably add it to IdentityServiceClient. If we can expose it also on native, it would be even better. And we should determine why there's an asymmetry of how the keys are uploaded and ideally make it consistent.
Comment Actions
Fair - if we already have the approach I will add it to IdentityServiceClient.
On native this method is used only from C++ level and is not exposed to JS.
Can you explain why we have a single call to handle both prekey rotation and publishing on native, but separate calls on web? Ideally we would have a unified approach across platforms.
Native:
It was introduced in D10600 and D10631. We first rotate prekeys, then attempt to upload and after success mark as published, - that's why we don't need to expose Identity call to JS.
Web:
I want to make the same approach here - but the difference is that publishPrekeysToIdentity has to be implemented in JS.
Separately, can you clarify if marking as published is handled separately?
It is - I'll add a diff later in the stack.
The asymmetry comes from the fact that on native Identity RPC is used only from the C++ level so it's "hidden" from the JS level - on the web this is not possible, but for now I don't think there is any benefit with exposing it on native. It could change after ENG-6490 and ENG-6768 are done.
| lib/types/identity-service-types.js | ||
|---|---|---|
| 128 ↗ | (On Diff #37487) | Might be good to rename this to publishWebPrekeys for clarity, and to add a comment explaining why we only have it for web |