Paths

Table of Contentst

Differential D11293

[lib] Add Tunnelbroker message types for QR code auth
ClosedPublic
Actions

Authored by bartek on Mar 11 2024, 6:17 AM.

Tags

None

Referenced Files

	F3877483: D11293.id37990.diff
	Thu, Jan 23, 12:47 PM

	F3877479: D11293.id38011.diff
	Thu, Jan 23, 12:47 PM

	F3877476: D11293.id.diff
	Thu, Jan 23, 12:47 PM

	F3877395: D11293.id38247.diff
	Thu, Jan 23, 12:45 PM

	F3877394: D11293.id37984.diff
	Thu, Jan 23, 12:45 PM

	F3877392: D11293.id38123.diff
	Thu, Jan 23, 12:45 PM

	F3877373: D11293.id37971.diff
	Thu, Jan 23, 12:44 PM

	F3876879: D11293.diff
	Thu, Jan 23, 12:31 PM

Subscribers

Details

Reviewers

kamil
michal

Commits

rCOMM9983dec2bb77: [lib] Add Tunnelbroker message types for QR code auth

Summary

Added a new peer-to-peer message type for QR code auth flow. All messages are going to be encrypted separately via AES-256.

Depends on D11292

Test Plan

TBD

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 11 2024, 6:17 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 11 2024, 6:17 AM

bartek added a child revision: D11294: [native] Update device list on QR code scaned.Mar 11 2024, 6:17 AM

Harbormaster failed remote builds in B27423: Diff 37971!Mar 11 2024, 6:31 AM

Rebase

Harbormaster failed remote builds in B27436: Diff 37984!Mar 11 2024, 7:02 AM

bartek edited the summary of this revision. (Show Details)Mar 11 2024, 7:05 AM

Rebase

Harbormaster failed remote builds in B27442: Diff 37990!Mar 11 2024, 7:32 AM

Fix lint

Harbormaster completed remote builds in B27462: Diff 38011.Mar 12 2024, 12:24 AM

bartek published this revision for review.Mar 12 2024, 1:37 AM

bartek added inline comments.

lib/utils/qr-code-auth.js
13 ↗	(On Diff #37984)	Messages are going to be encrypted using AES-256. This is going to be implemented in a further diff. For now it's just stub - the content is JSON-stringified in plaintext

kamil accepted this revision.Mar 13 2024, 5:35 AM

kamil added inline comments.

lib/types/tunnelbroker/peer-to-peer-message-types.js
60–63 ↗	(On Diff #38011)	are you sure, you don't need a `senderInfo` here? How do you plan to decrypt `encryptedContent` / establish session?

This revision is now accepted and ready to land.Mar 13 2024, 5:35 AM

ashoat added inline comments.Mar 13 2024, 9:47 AM

lib/types/tunnelbroker/peer-to-peer-message-types.js
60–63 ↗	(On Diff #38011)	I haven't looked too closely at this code, but let me know if there's any way I can help clarify the protocol

bartek added inline comments.Mar 14 2024, 2:07 AM

lib/types/tunnelbroker/peer-to-peer-message-types.js
60–63 ↗	(On Diff #38011)	Messages are AES-256 encrypted. The encryption key is a part of the QR code. So both parties can encrypt/decrypt.

Add backupLogDataKey to the backup message

Harbormaster completed remote builds in B27552: Diff 38123.Mar 18 2024, 5:07 AM

Closed by commit rCOMM9983dec2bb77: [lib] Add Tunnelbroker message types for QR code auth (authored by bartek). · Explain WhyMar 21 2024, 4:29 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9983dec2bb77: [lib] Add Tunnelbroker message types for QR code auth.

Revision Contents
Changeset List

Path

Size

lib/

types/

tunnelbroker/

peer-to-peer-message-types.js

15 lines

qr-code-auth-message-types.js

58 lines

utils/

qr-code-auth.js

34 lines

Diff 38247

lib/types/tunnelbroker/peer-to-peer-message-types.js

Loading...

lib/types/tunnelbroker/qr-code-auth-message-types.js

Loading...

lib/utils/qr-code-auth.js

Loading...