Paths

Table of Contentst

Differential D11330

[lib][native] Extract QR code to a spearate component
ClosedPublic
Actions

Authored by bartek on Mar 14 2024, 10:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 2:03 PM

	Unknown Object (File)
	Oct 27 2024, 8:20 AM

	Unknown Object (File)
	Oct 22 2024, 3:04 PM

	Unknown Object (File)
	Oct 22 2024, 3:04 PM

	Unknown Object (File)
	Oct 22 2024, 3:04 PM

	Unknown Object (File)
	Oct 22 2024, 3:04 PM

	Unknown Object (File)
	Oct 22 2024, 3:03 PM

	Unknown Object (File)
	Sep 27 2024, 6:17 AM

View All 59 Files

Subscribers

Details

Reviewers

kamil
michal

Commits

rCOMM713c509cbea7: [lib][native] Extract QR code to a spearate component

Summary

To avoid code duplication between web and native, extracted most of the secondary device auth logic into a separate React component.

Depends on D11301

Test Plan

Flow, repeated test plan from parent diffs in this stack (basically repeated the QR auth flow).

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 14 2024, 10:37 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 14 2024, 10:37 AM

bartek added a child revision: D11331: [web] Add QR auth handler logic.Mar 14 2024, 10:39 AM

Harbormaster completed remote builds in B27516: Diff 38081.Mar 14 2024, 10:52 AM

bartek published this revision for review.Mar 18 2024, 12:33 AM

Rebase

Harbormaster completed remote builds in B27558: Diff 38129.Mar 18 2024, 5:49 AM

kamil accepted this revision.Mar 18 2024, 8:11 AM

kamil added inline comments.

lib/components/qr-auth-handler.react.js
22–25 ↗	(On Diff #38129)	should be read-only
55–63 ↗	(On Diff #38129)	is there a need for it or could you just add `void sendMessage(.....`
131 ↗	(On Diff #38129)	nit

This revision is now accepted and ready to land.Mar 18 2024, 8:11 AM

bartek added inline comments.Mar 21 2024, 3:51 AM

lib/components/qr-auth-handler.react.js
55–63 ↗	(On Diff #38129)	Technically I could, but in the next diff, I'm replacing `createQRAuthTunnelbrokerMessage()` with an async function which needs to be awaited too

Address feedback

Harbormaster completed remote builds in B27634: Diff 38244.Mar 21 2024, 4:07 AM

Closed by commit rCOMM713c509cbea7: [lib][native] Extract QR code to a spearate component (authored by bartek). · Explain WhyMar 21 2024, 4:29 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM713c509cbea7: [lib][native] Extract QR code to a spearate component.

Revision Contents
Changeset List

Path

Size

lib/

components/

qr-auth-handler.react.js

136 lines

native/

qr-code/

qr-code-screen.react.js

157 lines

Diff 38081

lib/components/qr-auth-handler.react.js

Loading...

native/qr-code/qr-code-screen.react.js

Loading...