Page MenuHomePhabricator
Differential D11358

[native][web] Read integrity thread hashes from SQLite on app start
ClosedPublic
Actions

Authored by will on Mar 19 2024, 1:02 PM.
Tags
None
Referenced Files
F1751122: D11358.diff
Mon, May 13, 11:23 PM
Unknown Object (File)
Thu, May 9, 7:26 PM
Unknown Object (File)
Mon, Apr 29, 5:03 PM
Unknown Object (File)
Apr 7 2024, 8:17 PM
Unknown Object (File)
Apr 1 2024, 3:09 AM
Unknown Object (File)
Mar 31 2024, 1:11 PM
Unknown Object (File)
Mar 30 2024, 6:10 PM
Unknown Object (File)
Mar 25 2024, 7:19 PM
View All 10 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
atul
Commits
rCOMM5695216e237f: [native][web] Read integrity thread hashes from SQLite on app start
Summary

Get data from DB and populate store.

Depends on D11357

Test Plan

Test if contents are the same with the assert function

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Mar 19 2024, 1:02 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 19 2024, 1:02 PM
will added a child revision: D11359: [lib] integrity reducer tests.Mar 19 2024, 1:04 PM
Harbormaster completed remote builds in B27611: Diff 38207.Mar 19 2024, 1:18 PM
will requested review of this revision.Mar 19 2024, 1:18 PM
tomek accepted this revision.Mar 20 2024, 5:21 AM
tomek added 1 blocking reviewer(s): kamil.
kamil accepted this revision.Mar 22 2024, 3:28 AM
kamil added inline comments.
lib/reducers/integrity-reducer.js
36
This revision is now accepted and ready to land.Mar 22 2024, 3:28 AM
Closed by commit rCOMM5695216e237f: [native][web] Read integrity thread hashes from SQLite on app start (authored by will). · Explain WhyMar 25 2024, 2:11 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM5695216e237f: [native][web] Read integrity thread hashes from SQLite on app start.
ashoat added inline comments.Mar 26 2024, 1:08 PM
lib/reducers/integrity-reducer.js
36

This comment appears to have been ignored

will added a reverting change: D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".Mar 28 2024, 11:08 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
41 lines
1 line
1 line
types/
2 lines
native/
data/
7 lines
web/
shared-worker/
utils/
9 lines

Diff 38207

View Options

lib/reducers/integrity-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/reducers/message-reducer.test.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

web/shared-worker/utils/store.js

Loading...