Paths

Table of Contentst

-
lib/reducers/
-
reducers/
-
integrity-reducer.test.js

Differential D11359

[lib] integrity reducer tests
ClosedPublic
Actions

Authored by will on Mar 19 2024, 1:03 PM.

Tags

None

Referenced Files

	F5796019: D11359.diff
	Tue, Apr 15, 2:07 PM

	Unknown Object (File)
	Thu, Apr 10, 12:01 AM

	Unknown Object (File)
	Feb 21 2025, 5:20 AM

	Unknown Object (File)
	Feb 20 2025, 2:01 PM

	Unknown Object (File)
	Feb 20 2025, 10:30 AM

	Unknown Object (File)
	Feb 20 2025, 10:30 AM

	Unknown Object (File)
	Feb 20 2025, 10:30 AM

	Unknown Object (File)
	Feb 20 2025, 10:30 AM

Subscribers

Details

Reviewers

kamil
atul
tomek

Commits

rCOMM2c577fabda21: [lib] integrity reducer tests

Summary

This implements the integrity reducer tests

Depends on D11358

Test Plan

flow check. Successfully runs tests

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Mar 19 2024, 1:03 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 19 2024, 1:03 PM

will edited the summary of this revision. (Show Details)Mar 19 2024, 1:04 PM

will added a parent revision: D11358: [native][web] Read integrity thread hashes from SQLite on app start.

rebase

Harbormaster completed remote builds in B27612: Diff 38208.Mar 19 2024, 1:18 PM

Harbormaster completed remote builds in B27613: Diff 38209.Mar 19 2024, 1:22 PM

will requested review of this revision.Mar 19 2024, 1:22 PM

consts can be moved to specific unit tests

match style

Harbormaster completed remote builds in B27615: Diff 38211.Mar 19 2024, 3:04 PM

Harbormaster completed remote builds in B27616: Diff 38212.Mar 19 2024, 3:16 PM

tomek accepted this revision.Mar 20 2024, 5:22 AM

tomek added inline comments.

lib/reducers/integrity-reducer.test.js
88 ↗	(On Diff #38212)	It is a good practice to make the test description read like a sentence, e.g. `it('should update integrity store...`.

This revision is now accepted and ready to land.Mar 20 2024, 5:22 AM

Remove isDefault to pass flow check

review feedback

Harbormaster completed remote builds in B27667: Diff 38294.Mar 25 2024, 1:03 PM

Harbormaster completed remote builds in B27668: Diff 38300.Mar 25 2024, 1:18 PM

Closed by commit rCOMM2c577fabda21: [lib] integrity reducer tests (authored by will). · Explain WhyMar 25 2024, 2:11 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM2c577fabda21: [lib] integrity reducer tests.

will added a reverting change: D11456: Revert "[lib] integrity reducer tests".Mar 28 2024, 11:25 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

integrity-reducer.test.js

232 lines

Diff 38208

lib/reducers/integrity-reducer.test.js

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';
	import { View, Switch, TouchableOpacity, Platform } from 'react-native';			import { View, Switch, TouchableOpacity, Platform } from 'react-native';
	import Linking from 'react-native/Libraries/Linking/Linking.js';			import Linking from 'react-native/Libraries/Linking/Linking.js';

	import {			import {
	updateSubscriptionActionTypes,			updateSubscriptionActionTypes,
	updateSubscription,			useUpdateSubscription,
	} from 'lib/actions/user-actions.js';			} from 'lib/actions/user-actions.js';
	import type {			import type {
	SubscriptionUpdateRequest,			SubscriptionUpdateRequest,
	SubscriptionUpdateResult,			SubscriptionUpdateResult,
	} from 'lib/types/subscription-types.js';			} from 'lib/types/subscription-types.js';
	import { type ThreadInfo } from 'lib/types/thread-types.js';			import { type ThreadInfo } from 'lib/types/thread-types.js';
	import type { DispatchActionPromise } from 'lib/utils/action-utils.js';			import type { DispatchActionPromise } from 'lib/utils/action-utils.js';
	import {			import { useDispatchActionPromise } from 'lib/utils/action-utils.js';
	useServerCall,
	useDispatchActionPromise,
	} from 'lib/utils/action-utils.js';

	import SingleLine from '../../components/single-line.react.js';			import SingleLine from '../../components/single-line.react.js';
	import SWMansionIcon from '../../components/swmansion-icon.react.js';			import SWMansionIcon from '../../components/swmansion-icon.react.js';
	import { CommAndroidNotifications } from '../../push/android.js';			import { CommAndroidNotifications } from '../../push/android.js';
	import { useSelector } from '../../redux/redux-utils.js';			import { useSelector } from '../../redux/redux-utils.js';
	import { useStyles } from '../../themes/colors.js';			import { useStyles } from '../../themes/colors.js';
	import Alert from '../../utils/alert.js';			import Alert from '../../utils/alert.js';

	▲ Show 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
	};			};

	const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> =			const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> =
	React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs(			React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs(
	props: BaseProps,			props: BaseProps,
	) {			) {
	const styles = useStyles(unboundStyles);			const styles = useStyles(unboundStyles);
	const dispatchActionPromise = useDispatchActionPromise();			const dispatchActionPromise = useDispatchActionPromise();
	const callUpdateSubscription = useServerCall(updateSubscription);			const callUpdateSubscription = useUpdateSubscription();
	const hasPushPermissions = useSelector(			const hasPushPermissions = useSelector(
	state => state.deviceToken !== null && state.deviceToken !== undefined,			state => state.deviceToken !== null && state.deviceToken !== undefined,
	);			);
	return (			return (
	<ThreadSettingsPushNotifs			<ThreadSettingsPushNotifs
	{...props}			{...props}
	styles={styles}			styles={styles}
	dispatchActionPromise={dispatchActionPromise}			dispatchActionPromise={dispatchActionPromise}
	updateSubscription={callUpdateSubscription}			updateSubscription={callUpdateSubscription}
	hasPushPermissions={hasPushPermissions}			hasPushPermissions={hasPushPermissions}
	/>			/>
	);			);
	});			});

	export default ConnectedThreadSettingsPushNotifs;			export default ConnectedThreadSettingsPushNotifs;