Page MenuHomePhabricator
Differential D11359

[lib] integrity reducer tests
ClosedPublic
Actions

Authored by will on Mar 19 2024, 1:03 PM.
Tags
None
Referenced Files
F1762627: D11359.diff
Tue, May 14, 8:45 PM
Unknown Object (File)
Wed, May 8, 3:27 PM
Unknown Object (File)
Wed, May 8, 1:59 PM
Unknown Object (File)
Tue, May 7, 8:15 PM
Unknown Object (File)
Apr 1 2024, 11:46 AM
Unknown Object (File)
Apr 1 2024, 8:02 AM
Unknown Object (File)
Apr 1 2024, 5:30 AM
Unknown Object (File)
Apr 1 2024, 3:27 AM
View All 16 Files
Subscribers
ashoat

Details

Reviewers
kamil
atul
tomek
Commits
rCOMM2c577fabda21: [lib] integrity reducer tests
Summary

This implements the integrity reducer tests

Depends on D11358

Test Plan

flow check. Successfully runs tests

Diff Detail

Repository
rCOMM Comm
Branch
sqlite/integrityStore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Mar 19 2024, 1:03 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 19 2024, 1:03 PM
will edited the summary of this revision. (Show Details)Mar 19 2024, 1:04 PM
will added a parent revision: D11358: [native][web] Read integrity thread hashes from SQLite on app start.
will updated this revision to Diff 38209.Mar 19 2024, 1:08 PM

rebase

Harbormaster completed remote builds in B27612: Diff 38208.Mar 19 2024, 1:18 PM
Harbormaster completed remote builds in B27613: Diff 38209.Mar 19 2024, 1:22 PM
will requested review of this revision.Mar 19 2024, 1:22 PM
will updated this revision to Diff 38211.Mar 19 2024, 2:48 PM

consts can be moved to specific unit tests

will updated this revision to Diff 38212.Mar 19 2024, 3:00 PM

match style

Harbormaster completed remote builds in B27615: Diff 38211.Mar 19 2024, 3:04 PM
Harbormaster completed remote builds in B27616: Diff 38212.Mar 19 2024, 3:16 PM
tomek accepted this revision.Mar 20 2024, 5:22 AM
tomek added inline comments.
lib/reducers/integrity-reducer.test.js
88 ↗(On Diff #38212)

It is a good practice to make the test description read like a sentence, e.g. it('should update integrity store....

This revision is now accepted and ready to land.Mar 20 2024, 5:22 AM
will updated this revision to Diff 38294.Mar 25 2024, 12:40 PM

Remove isDefault to pass flow check

will updated this revision to Diff 38300.Mar 25 2024, 12:54 PM

review feedback

Harbormaster completed remote builds in B27667: Diff 38294.Mar 25 2024, 1:03 PM
Harbormaster completed remote builds in B27668: Diff 38300.Mar 25 2024, 1:18 PM
Closed by commit rCOMM2c577fabda21: [lib] integrity reducer tests (authored by will). · Explain WhyMar 25 2024, 2:11 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM2c577fabda21: [lib] integrity reducer tests.
will added a reverting change: D11456: Revert "[lib] integrity reducer tests".Mar 28 2024, 11:25 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
230 lines

Diff 38300

View Options

lib/reducers/integrity-reducer.test.js

Loading...