[lib] Create a wrapper over dispatch
ClosedPublic
Actions

Authored by tomek on Mar 21 2024, 8:26 AM.

Details

Reviewers

kamil
inka
will

Commits

rCOMM8a655eac7f4e: [lib] Create a wrapper over dispatch

Summary

We're adding a messageID field to an action if it is provided

https://linear.app/comm/issue/ENG-7106/create-a-context

Depends on D11368

Test Plan

Use the new dispatch function and verify that the store gets updated. Check if the ops are being processed and that the queue's length decreases with each processing.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Mar 21 2024, 8:26 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 21 2024, 8:26 AM

tomek added a child revision: D11370: [lib] Resolve the promise after processing is done.Mar 21 2024, 8:31 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2024, 8:37 AM

Harbormaster failed remote builds in B27650: Diff 38271!

Instead of creating a context we can have a simple hook

tomek retitled this revision from [lib] Create a context providing a wrapper over dispatch to [lib] Create a wrapper over dispatch.Mar 27 2024, 9:02 AM

tomek edited the summary of this revision. (Show Details)

tomek edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B27710: Diff 38373.Mar 27 2024, 9:18 AM

tomek requested review of this revision.Mar 27 2024, 9:18 AM

kamil accepted this revision.Mar 28 2024, 3:54 AM

kamil added inline comments.