plugin-transform-private-methods to list of plugins
ClosedPublic
Actions

Authored by ginsu on Mar 27 2024, 9:00 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM62b3601c95c9: [keyserver/landing] add @babel/plugin-transform-private-methods to list of…

Summary

The day before the hackathon @ashoat and I were debugging an issue where the farcaster app signin redirect url was not being returned with the WebView. As we were working on a solution where we need to run yarn prod in landing + yarn prod-build && yarn prod in keyserver we were getting some babel issues that were resolved by adding the plugins in this diff

Linear task w/ discussion about the issue @ashoat and I were trying to solve: https://linear.app/comm/issue/ENG-7325/connect-to-farcaster-wo-siwn

Added the babel plugins + ran yarn cleaninstall

Made @ashoat blocking since this diff adds a dependency + new babel plugins

Depends on D11426

Test Plan

N/A + was able to test the entire SIWF flow during the hackathon + was able to run yarn prod in landing + yarn prod-build && yarn prod in keyserver w/o getting any errors

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 27 2024, 9:00 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 27 2024, 9:01 PM

ginsu edited the summary of this revision. (Show Details)Mar 27 2024, 9:05 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D11426: [landing] add @farcaster/auth-kit dep.

ginsu edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B27746: Diff 38409.Mar 27 2024, 9:16 PM

ginsu requested review of this revision.Mar 27 2024, 9:16 PM

ginsu added a child revision: D11428: [landing] introduce ConnectFarcaster.Mar 27 2024, 9:16 PM

atul accepted this revision.Mar 28 2024, 5:43 AM

We should include the new package in keyserver/package.json since it's used in keyserver/.babelrc.cjs. It doesn't cause any issues right now because the package isn't getting hoisted, but subtle changes to dependencies could change that.

This revision now requires changes to proceed.Mar 28 2024, 6:41 AM

In D11427#329531, @ashoat wrote:

We should include the new package in keyserver/package.json since it's used in keyserver/.babelrc.cjs. It doesn't cause any issues right now because the package isn't getting hoisted, but subtle changes to dependencies could change that.

Got it. Will fix that now. Thanks for taking the time to explain this to me