Page MenuHomePhabricator

[landing] introduce ConnectFarcaster
ClosedPublic

Authored by ginsu on Mar 27 2024, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:44 AM
Unknown Object (File)
Tue, Nov 12, 10:39 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:45 PM
Unknown Object (File)
Oct 11 2024, 11:31 AM
Unknown Object (File)
Sep 18 2024, 8:20 AM
Subscribers

Details

Summary

introduce ConnectFarcaster component. This component should return null as the purpose of this component is to call the useSignIn hook from @farcaster/auth-kit and return it to the react native webview component (introduced in subsequent diffs)

Depends on D11427

Test Plan

Confirmed that I was able to get both the farcaster_url and the farcaster_data back in the native message webview whenever this component was rendered in the native webview component + tested the entire sign in flow during the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Mar 27 2024, 9:30 PM
atul added inline comments.
landing/connect-farcaster.react.js
80 ↗(On Diff #38410)

Do we really need this?

84–88 ↗(On Diff #38410)

Wouldn't hurt to memoize

This revision is now accepted and ready to land.Mar 28 2024, 5:49 AM
landing/connect-farcaster.react.js
80 ↗(On Diff #38410)

I believe so... I don't think undefined is a valid React.Node

landing/connect-farcaster.react.js
80 ↗(On Diff #38410)

Oh wait, totally my mistake. I lost track of opening/closing braces and thought this was inside the useEffect.

This is totally fine

This revision was automatically updated to reflect the committed changes.