Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 28, 12:36 PM

	Unknown Object (File)
	Sat, Dec 28, 12:36 PM

	Unknown Object (File)
	Sat, Dec 28, 12:36 PM

	Unknown Object (File)
	Sat, Dec 28, 12:36 PM

	Unknown Object (File)
	Sat, Dec 28, 12:35 PM

	Unknown Object (File)
	Nov 30 2024, 5:08 AM

	Unknown Object (File)
	Nov 27 2024, 2:51 AM

	Unknown Object (File)
	Nov 27 2024, 12:46 AM

View All 56 Files

Subscribers

ashoat

Details

Reviewers

ginsu
will
varun
tomek

Commits

rCOMM66a4e39bb7bf: [lib] Fix `UpdateRelationshipMessageSpec.validator`

Summary

Based on https://github.com/CommE2E/comm/commit/f83bf3a95128fae846cb155720f6ac7851d517bd

Depends on D11455

Test Plan

Unit tests in validation.test.js cover this

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 28 2024, 11:34 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 28 2024, 11:34 AM

Harbormaster completed remote builds in B27796: Diff 38491.Mar 28 2024, 11:49 AM

atul requested review of this revision.Mar 28 2024, 11:49 AM

atul added a child revision: D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.Mar 28 2024, 12:11 PM

ginsu accepted this revision.Mar 28 2024, 8:43 PM

This revision is now accepted and ready to land.Mar 28 2024, 8:43 PM

land

This revision was landed with ongoing or failed builds.Apr 4 2024, 1:01 PM

Closed by commit rCOMM66a4e39bb7bf: [lib] Fix `UpdateRelationshipMessageSpec.validator` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM66a4e39bb7bf: [lib] Fix `UpdateRelationshipMessageSpec.validator`.

Harbormaster completed remote builds in B27995: Diff 38799.Apr 4 2024, 1:03 PM

[lib] Fix `UpdateRelationshipMessageSpec.validator`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 38806

lib/shared/messages/update-relationship-message-spec.js

[lib] Fix `UpdateRelationshipMessageSpec.validator`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38806

lib/shared/messages/update-relationship-message-spec.js

[lib] Fix `UpdateRelationshipMessageSpec.validator`
ClosedPublic
Actions

Revision Contents
Changeset List