Page MenuHomePhabricator

[lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`
ClosedPublic

Authored by atul on Mar 28 2024, 12:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 7:33 PM
Unknown Object (File)
Fri, Feb 28, 7:33 PM
Unknown Object (File)
Feb 3 2025, 1:28 PM
Unknown Object (File)
Feb 1 2025, 10:12 AM
Unknown Object (File)
Jan 30 2025, 1:55 PM
Unknown Object (File)
Jan 30 2025, 1:55 PM
Unknown Object (File)
Jan 30 2025, 1:55 PM
Unknown Object (File)
Jan 30 2025, 1:55 PM
Subscribers

Details

Summary

Shim UpdateRelationship messages with farcaster_mutual operation for now.

Based on the following from hackathon branch: https://github.com/CommE2E/comm/commit/6dcee7ca9c467951a11086fce416c85bb7f3d385


Depends on D11458

Test Plan

Unsupported robotext appears as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Mar 28 2024, 1:10 PM

I previously reviewed this code in person

lib/shared/messages/update-relationship-message-spec.js
241 ↗(On Diff #38494)

Can we avoid copy-pasting this?

Line 196 can be:

ET`${string}`
This revision is now accepted and ready to land.Mar 28 2024, 7:09 PM

address feedback + land

This revision was landed with ongoing or failed builds.Apr 8 2024, 6:17 AM
This revision was automatically updated to reflect the committed changes.