Page MenuHomePhabricator
Differential D11458

[lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`
ClosedPublic
Actions

Authored by atul on Mar 28 2024, 12:11 PM.
Tags
None
Referenced Files
F3572718: D11458.id38877.diff
Sat, Dec 28, 12:36 PM
F3572717: D11458.id38876.diff
Sat, Dec 28, 12:36 PM
F3572716: D11458.id38492.diff
Sat, Dec 28, 12:36 PM
F3572707: D11458.id.diff
Sat, Dec 28, 12:36 PM
F3572706: D11458.diff
Sat, Dec 28, 12:36 PM
F3571703: D11458.id.diff
Sat, Dec 28, 9:40 AM
Unknown Object (File)
Wed, Dec 25, 4:21 AM
Unknown Object (File)
Thu, Dec 19, 11:34 PM
View All Files
Subscribers
ashoat

Details

Reviewers
ashoat
ginsu
varun
tomek
will
Commits
rCOMM444cce2542c3: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`
Summary

Show different message in robotext/notificationTexts when operation is of type farcaster_mutual.

Based on https://github.com/CommE2E/comm/commit/7d43cd1575df7b6f0a23d0e5dd88d63bbfab7bf8

(adding @ashoat as blocking to get sign off on copy)

Depends on D11457

Test Plan

Appears as expected:

3be31b.png (2×1 px, 736 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 28 2024, 12:11 PM
atul published this revision for review.Mar 28 2024, 12:12 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B27797: Diff 38492.Mar 28 2024, 12:39 PM
atul added a child revision: D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.Mar 28 2024, 12:54 PM
ashoat accepted this revision.Mar 28 2024, 4:30 PM

We have ENG-7514 to track improving the robotext here, so that it mentions the user's Farcaster username

If we add NeynarClient to keyserver, then we can do it for notifs too

lib/shared/messages/update-relationship-message-spec.js
226–227 ↗(On Diff #38492)

I wonder if we should add an invariant here for safety

This revision is now accepted and ready to land.Mar 28 2024, 4:30 PM
atul updated this revision to Diff 38876.Apr 5 2024, 4:38 PM

address feedback

This revision was landed with ongoing or failed builds.Apr 5 2024, 4:41 PM
Closed by commit rCOMM444cce2542c3: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM444cce2542c3: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.
Harbormaster completed remote builds in B28031: Diff 38876.Apr 5 2024, 4:54 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
18 lines

Diff 38877

View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...