Page MenuHomePhabricator
Differential D11463

[native] introduce already connected button to farcaster connect
ClosedPublic
Actions

Authored by ginsu on Mar 28 2024, 10:05 PM.
Tags
None
Referenced Files
F3375697: D11463.diff
Tue, Nov 26, 8:52 PM
Unknown Object (File)
Sat, Nov 16, 5:20 PM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 11 2024, 11:16 AM
Unknown Object (File)
Sep 18 2024, 8:19 AM
View All 40 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMMddfda1a8134d: [native] introduce already connected button to farcaster connect
Summary

This diff introduces the last part to the FarcasterConnect screen: Already connected button. If for some reason the user navigates backwards through the flow + they have already signed in with farcaster, we will show this button so that they do not need to re-sign in with farcaster again to move forward to where they originally were

Depends on D11462

Test Plan

Please see the demo video + tested the entire sign in flow during the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 28 2024, 10:05 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 10:07 PM
Harbormaster failed remote builds in B27805: Diff 38522!
ginsu requested review of this revision.Mar 28 2024, 10:08 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.
ginsu attached a referenced file: F1440518: RPReplay_Final1711688497.MP4. (Show Details)

will make sure the ci passes before landing

atul accepted this revision.Mar 29 2024, 1:28 PM
This revision is now accepted and ready to land.Mar 29 2024, 1:28 PM
Harbormaster completed remote builds in B27805: Diff 38522.Mar 29 2024, 2:13 PM
Closed by commit rCOMMddfda1a8134d: [native] introduce already connected button to farcaster connect (authored by ginsu). · Explain WhyMar 29 2024, 2:20 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMddfda1a8134d: [native] introduce already connected button to farcaster connect.
ginsu added a child revision: D11483: [native] introduce farcaster account settings profile row.Mar 29 2024, 2:32 PM

Revision Contents
Changeset List

PathSize
native/
account/
registration/
42 lines

Diff 38522

View Options

native/account/registration/connect-farcaster.react.js

Loading...