[native] calculate snap points for connect farcaster bottom sheet
ClosedPublic
Actions

Authored by ginsu on Apr 4 2024, 12:16 PM.

Details

Reviewers

atul
inka

Commits

rCOMM120db72b9482: [native] calculate snap points for connect farcaster bottom sheet

Summary

In order to correctly get our bottom sheet to snap up to the correct height we need to measure the height of the content of the connect farcaster bottom sheet. To get the correct height of the content, I used the built in element inspector and was able to get the height of each individual piece of the content

Linear task: https://linear.app/comm/issue/ENG-7523/determine-the-content-height-of-the-bottom-sheet

Depends on D11560

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 4 2024, 12:16 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 4 2024, 12:16 PM

ginsu edited the summary of this revision. (Show Details)Apr 4 2024, 12:19 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D11560: [native] implement connect farcaster bottom sheet ui.

ginsu attached a referenced file: F1466979: Screen Recording 2024-04-04 at 3.19.12 PM.mov. (Show Details)

ginsu added inline comments.

native/components/connect-farcaster-bottom-sheet.react.js
18 ↗	(On Diff #38790)	Rather than just show the final sum, I thought it would be better to show the math in case we ever add to this bottom sheet or make changes to the content in the future

will make sure ci passes before landing

Harbormaster failed remote builds in B27988: Diff 38790!Apr 4 2024, 12:31 PM

atul accepted this revision.Apr 4 2024, 1:44 PM

atul added inline comments.

native/components/connect-farcaster-bottom-sheet.react.js
18 ↗	(On Diff #38790)	Makes sense Could also make separate variables like const farcasterPromptHeight = 350 const marginBottomHeight = 40 and let the variable names do explaining vs the comment which you'll have to update every time the calculation changes?