Page MenuHomePhabricator
Differential D11561

[native] calculate snap points for connect farcaster bottom sheet
ClosedPublic
Actions

Authored by ginsu on Thu, Apr 4, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 12:22 PM
Unknown Object (File)
Tue, Apr 16, 9:47 PM
Unknown Object (File)
Tue, Apr 16, 5:30 AM
Unknown Object (File)
Sat, Apr 13, 9:12 PM
Unknown Object (File)
Sat, Apr 13, 3:26 PM
Unknown Object (File)
Sat, Apr 13, 2:22 PM
Unknown Object (File)
Fri, Apr 12, 10:41 AM
Unknown Object (File)
Thu, Apr 11, 3:44 PM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM120db72b9482: [native] calculate snap points for connect farcaster bottom sheet
Summary

In order to correctly get our bottom sheet to snap up to the correct height we need to measure the height of the content of the connect farcaster bottom sheet. To get the correct height of the content, I used the built in element inspector and was able to get the height of each individual piece of the content

Linear task: https://linear.app/comm/issue/ENG-7523/determine-the-content-height-of-the-bottom-sheet

Depends on D11560

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Thu, Apr 4, 12:16 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 4, 12:16 PM
ginsu edited the summary of this revision. (Show Details)Thu, Apr 4, 12:19 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11560: [native] implement connect farcaster bottom sheet ui.
ginsu attached a referenced file: F1466979: Screen Recording 2024-04-04 at 3.19.12 PM.mov. (Show Details)
ginsu added inline comments.
native/components/connect-farcaster-bottom-sheet.react.js
18 ↗(On Diff #38790)

Rather than just show the final sum, I thought it would be better to show the math in case we ever add to this bottom sheet or make changes to the content in the future

ginsu published this revision for review.Thu, Apr 4, 12:22 PM

will make sure ci passes before landing

Harbormaster failed remote builds in B27988: Diff 38790!Thu, Apr 4, 12:31 PM
atul accepted this revision.Thu, Apr 4, 1:44 PM
atul added inline comments.
native/components/connect-farcaster-bottom-sheet.react.js
18 ↗(On Diff #38790)

Makes sense

Could also make separate variables like

const farcasterPromptHeight = 350
const marginBottomHeight = 40

and let the variable names do explaining vs the comment which you'll have to update every time the calculation changes?

This revision is now accepted and ready to land.Thu, Apr 4, 1:44 PM
ginsu updated this revision to Diff 38819.Thu, Apr 4, 7:27 PM

address comments + rebase before landing

Harbormaster completed remote builds in B28008: Diff 38819.Thu, Apr 4, 7:43 PM
Closed by commit rCOMM120db72b9482: [native] calculate snap points for connect farcaster bottom sheet (authored by ginsu). · Explain WhyThu, Apr 4, 8:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM120db72b9482: [native] calculate snap points for connect farcaster bottom sheet.
ginsu added a child revision: D11597: [native] flip farcaster prompt based on fid prop instead of context.Tue, Apr 9, 10:01 AM

Revision Contents
Changeset List

PathSize
native/
components/
24 lines

Diff 38827

View Options

native/components/connect-farcaster-bottom-sheet.react.js

Loading...