Page MenuHomePhabricator
Differential D11599

[lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file
ClosedPublic
Actions

Authored by ginsu on Apr 9 2024, 10:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 8:12 PM
Unknown Object (File)
Wed, Mar 5, 6:24 AM
Unknown Object (File)
Wed, Mar 5, 6:24 AM
Unknown Object (File)
Wed, Mar 5, 6:24 AM
Unknown Object (File)
Wed, Mar 5, 6:24 AM
Unknown Object (File)
Wed, Mar 5, 6:24 AM
Unknown Object (File)
Fri, Feb 28, 10:45 PM
Unknown Object (File)
Feb 4 2025, 6:17 PM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate…
Summary

Move diff. Took a second to move recordNotifPermissionAlertActionType into its own actions file to ensure + maintain consistency within our codebase

Depends on D11569

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 9 2024, 10:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 9 2024, 10:19 AM
ginsu edited the summary of this revision. (Show Details)Apr 9 2024, 10:20 AM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.
Harbormaster completed remote builds in B28099: Diff 38954.Apr 9 2024, 10:35 AM
ginsu requested review of this revision.Apr 9 2024, 10:35 AM
ginsu added a child revision: D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.Apr 9 2024, 12:06 PM
atul accepted this revision.Apr 10 2024, 10:05 AM
This revision is now accepted and ready to land.Apr 10 2024, 10:05 AM
ginsu updated this revision to Diff 39012.Apr 10 2024, 12:35 PM

rebase

Harbormaster completed remote builds in B28144: Diff 39012.Apr 10 2024, 1:08 PM
Closed by commit rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate… (authored by ginsu). · Explain WhyApr 10 2024, 1:32 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate….

Revision Contents
Changeset List

PathSize
lib/
actions/
5 lines
reducers/
2 lines
utils/
4 lines
native/
push/
6 lines
web/
push-notif/
6 lines

Diff 39020

View Options

lib/actions/alert-actions.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };
View Options

lib/reducers/alert-reducer.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };
View Options

lib/utils/push-alerts.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };
View Options

native/push/push-handler.react.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };
View Options

web/push-notif/push-notifs-handler.js

Loading...