Page MenuHomePhabricator
Differential D11599

[lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file
ClosedPublic
Actions

Authored by ginsu on Tue, Apr 9, 10:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 3:07 PM
Unknown Object (File)
Thu, Apr 18, 11:19 AM
Unknown Object (File)
Wed, Apr 17, 8:00 PM
Unknown Object (File)
Wed, Apr 17, 4:31 PM
Unknown Object (File)
Wed, Apr 17, 12:11 AM
Unknown Object (File)
Tue, Apr 16, 10:29 PM
Unknown Object (File)
Tue, Apr 16, 10:35 AM
Unknown Object (File)
Tue, Apr 16, 7:04 AM
View All 13 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate…
Summary

Move diff. Took a second to move recordNotifPermissionAlertActionType into its own actions file to ensure + maintain consistency within our codebase

Depends on D11569

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Tue, Apr 9, 10:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Apr 9, 10:19 AM
ginsu edited the summary of this revision. (Show Details)Tue, Apr 9, 10:20 AM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.
Harbormaster completed remote builds in B28099: Diff 38954.Tue, Apr 9, 10:35 AM
ginsu requested review of this revision.Tue, Apr 9, 10:35 AM
ginsu added a child revision: D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.Tue, Apr 9, 12:06 PM
atul accepted this revision.Wed, Apr 10, 10:05 AM
This revision is now accepted and ready to land.Wed, Apr 10, 10:05 AM
ginsu updated this revision to Diff 39012.Wed, Apr 10, 12:35 PM

rebase

Harbormaster completed remote builds in B28144: Diff 39012.Wed, Apr 10, 1:08 PM
Closed by commit rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate… (authored by ginsu). · Explain WhyWed, Apr 10, 1:32 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate….

Revision Contents
Changeset List

PathSize
lib/
actions/
5 lines
reducers/
2 lines
utils/
4 lines
native/
push/
6 lines
web/
push-notif/
6 lines

Diff 39020

View Options

lib/actions/alert-actions.js

Loading...
View Options

lib/reducers/alert-reducer.js

Loading...
View Options

lib/utils/push-alerts.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

web/push-notif/push-notifs-handler.js

Loading...