Page MenuHomePhabricator
Differential D11568

[lib/native/web] refactor notif permission alert info reducer
ClosedPublic
Actions

Authored by ginsu on Sun, Apr 7, 8:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 8:22 AM
Unknown Object (File)
Sun, Apr 21, 1:38 AM
Unknown Object (File)
Fri, Apr 19, 12:35 PM
Unknown Object (File)
Wed, Apr 17, 2:12 PM
Unknown Object (File)
Tue, Apr 16, 1:13 PM
Unknown Object (File)
Mon, Apr 15, 10:54 PM
Unknown Object (File)
Mon, Apr 15, 12:24 PM
Unknown Object (File)
Sun, Apr 14, 12:30 PM
View All 16 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM05921b8302a9: [lib/native/web] refactor notif permission alert info reducer
Summary

This diff refactors the notif permission alert info reducer => alert info reducer. Aside from just renaming the reducer, the reducer now returns an AlertStore instead of just an AlertInfo

Please note this diff + subsequent diffs won't be landed until the migration diff which will be introduced here shortly

Linear task: https://linear.app/comm/issue/ENG-7619/rename-all-the-notifpermissionalertinfo-⇒-alertinfo + https://linear.app/comm/issue/ENG-7621/refactor-reducenotifpermissionalertinfo-to-handle-a-mapping-of-alert

Depends on D11567

Test Plan

flow + confirmed the redux state using the redux dev tools and that the existing push notif permission alert still functions as expected

web:

Screenshot 2024-04-07 at 11.42.37 PM.png (288×1 px, 63 KB)

native:

Screenshot 2024-04-07 at 11.49.24 PM.png (110×644 px, 26 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sun, Apr 7, 8:36 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSun, Apr 7, 8:36 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Apr 7, 8:38 PM
Harbormaster failed remote builds in B28034: Diff 38880!
ginsu edited the summary of this revision. (Show Details)Sun, Apr 7, 8:40 PM
ginsu added reviewers: atul, inka, kamil.
ginsu added a parent revision: D11567: [lib/native/web] introduce alert types.
ginsu edited the summary of this revision. (Show Details)Sun, Apr 7, 8:50 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu updated this revision to Diff 38881.Sun, Apr 7, 8:54 PM
ginsu edited the test plan for this revision. (Show Details)

update

ginsu removed a reviewer: kamil.Sun, Apr 7, 8:54 PM
ginsu edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Apr 7, 8:56 PM
Harbormaster failed remote builds in B28035: Diff 38881!
ginsu requested review of this revision.Sun, Apr 7, 8:56 PM

will make sure ci passes before landing

ginsu added a child revision: D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.Sun, Apr 7, 9:01 PM
atul accepted this revision.Mon, Apr 8, 6:27 AM
This revision is now accepted and ready to land.Mon, Apr 8, 6:27 AM
ginsu updated this revision to Diff 39010.Wed, Apr 10, 12:33 PM

rebase + confirm ci passes

Harbormaster completed remote builds in B28142: Diff 39010.Wed, Apr 10, 12:56 PM
Closed by commit rCOMM05921b8302a9: [lib/native/web] refactor notif permission alert info reducer (authored by ginsu). · Explain WhyWed, Apr 10, 1:32 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM05921b8302a9: [lib/native/web] refactor notif permission alert info reducer.

Revision Contents
Changeset List

PathSize
lib/
reducers/
24 lines
7 lines
types/
4 lines
utils/
8 lines
native/
push/
4 lines
redux/
8 lines
4 lines
web/
push-notif/
3 lines
redux/
8 lines
4 lines

Diff 39018

View Options

lib/reducers/alert-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/reducers/notif-permission-alert-info-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/push-notif/push-notifs-handler.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/redux-setup.js

Loading...