Page MenuHomePhabricator
Differential D11569

[lib/native/web] introduce CONNECT_FARCASTER alert type
ClosedPublic
Actions

Authored by ginsu on Sun, Apr 7, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 9:25 AM
Unknown Object (File)
Wed, Apr 17, 5:25 AM
Unknown Object (File)
Wed, Apr 17, 5:01 AM
Unknown Object (File)
Mon, Apr 15, 6:27 PM
Unknown Object (File)
Mon, Apr 15, 5:35 PM
Unknown Object (File)
Mon, Apr 15, 2:11 PM
Unknown Object (File)
Sat, Apr 13, 7:10 PM
Unknown Object (File)
Sat, Apr 13, 5:04 PM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type
Summary

This diff introduces CONNECT_FARCASTER to the alertTypes object. This will be used to alert exisiting comm users to connect to farcaster. Additionally I introduced defaultAlertInfos since this logic will be repeated in multiple places

Linear task: https://linear.app/comm/issue/ENG-7622/refactor-defaultnotifpermissionalertinfo

Depends on D11568

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sun, Apr 7, 9:00 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSun, Apr 7, 9:00 PM
ginsu edited the summary of this revision. (Show Details)Sun, Apr 7, 9:01 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11568: [lib/native/web] refactor notif permission alert info reducer.
Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Apr 7, 9:02 PM
Harbormaster failed remote builds in B28036: Diff 38882!
ginsu requested review of this revision.Sun, Apr 7, 9:18 PM

will make sure ci passes before landing

atul accepted this revision.Mon, Apr 8, 6:29 AM
This revision is now accepted and ready to land.Mon, Apr 8, 6:29 AM
ginsu added a child revision: D11599: [lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file.Tue, Apr 9, 10:20 AM
ginsu updated this revision to Diff 39011.Wed, Apr 10, 12:34 PM

rebase + confirm ci passes

Harbormaster completed remote builds in B28143: Diff 39011.Wed, Apr 10, 1:03 PM
Closed by commit rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type (authored by ginsu). · Explain WhyWed, Apr 10, 1:32 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines
utils/
6 lines
native/
redux/
6 lines
web/
redux/
6 lines

Diff 39019

View Options

lib/types/alert-types.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

web/redux/default-state.js

Loading...