Page MenuHomePhabricator

[lib/native/web] introduce CONNECT_FARCASTER alert type
ClosedPublic

Authored by ginsu on Apr 7 2024, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 8:33 AM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Sep 30 2024, 6:56 AM
Unknown Object (File)
Sep 8 2024, 8:07 AM
Subscribers

Details

Summary

This diff introduces CONNECT_FARCASTER to the alertTypes object. This will be used to alert exisiting comm users to connect to farcaster. Additionally I introduced defaultAlertInfos since this logic will be repeated in multiple places

Linear task: https://linear.app/comm/issue/ENG-7622/refactor-defaultnotifpermissionalertinfo

Depends on D11568

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2024, 9:02 PM
Harbormaster failed remote builds in B28036: Diff 38882!
ginsu requested review of this revision.Apr 7 2024, 9:18 PM

will make sure ci passes before landing

This revision is now accepted and ready to land.Apr 8 2024, 6:29 AM

rebase + confirm ci passes