Page MenuHomePhabricator
Differential D11569

[lib/native/web] introduce CONNECT_FARCASTER alert type
ClosedPublic
Actions

Authored by ginsu on Apr 7 2024, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 8:33 AM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Sep 30 2024, 6:56 AM
Unknown Object (File)
Sep 8 2024, 8:07 AM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type
Summary

This diff introduces CONNECT_FARCASTER to the alertTypes object. This will be used to alert exisiting comm users to connect to farcaster. Additionally I introduced defaultAlertInfos since this logic will be repeated in multiple places

Linear task: https://linear.app/comm/issue/ENG-7622/refactor-defaultnotifpermissionalertinfo

Depends on D11568

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 7 2024, 9:00 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 7 2024, 9:00 PM
ginsu edited the summary of this revision. (Show Details)Apr 7 2024, 9:01 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11568: [lib/native/web] refactor notif permission alert info reducer.
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2024, 9:02 PM
Harbormaster failed remote builds in B28036: Diff 38882!
ginsu requested review of this revision.Apr 7 2024, 9:18 PM

will make sure ci passes before landing

atul accepted this revision.Apr 8 2024, 6:29 AM
This revision is now accepted and ready to land.Apr 8 2024, 6:29 AM
ginsu added a child revision: D11599: [lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file.Apr 9 2024, 10:20 AM
ginsu updated this revision to Diff 39011.Apr 10 2024, 12:34 PM

rebase + confirm ci passes

Harbormaster completed remote builds in B28143: Diff 39011.Apr 10 2024, 1:03 PM
Closed by commit rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type (authored by ginsu). · Explain WhyApr 10 2024, 1:32 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines
utils/
6 lines
native/
redux/
6 lines
web/
redux/
6 lines

Diff 38882

View Options

lib/types/alert-types.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

web/redux/default-state.js

Loading...