[lib] Fix sorting local messages
ClosedPublic
Actions

Authored by inka on Apr 5 2024, 3:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 19, 11:09 PM

	Unknown Object (File)
	Sun, May 19, 11:09 PM

	Unknown Object (File)
	Sun, May 19, 11:09 PM

	Unknown Object (File)
	Sun, May 19, 11:09 PM

	Unknown Object (File)
	Sat, May 18, 4:03 PM

	Unknown Object (File)
	Fri, May 17, 8:42 AM

	Unknown Object (File)
	Apr 17 2024, 10:02 PM

	Unknown Object (File)
	Apr 16 2024, 8:28 AM

View All 16 Files

Subscribers

ashoat

Details

Reviewers

michal
tomek

Commits

rCOMM57aa051186e2: [lib] Fix sorting local messages

Summary

issue: ENG-7651
The sorting was wroken for local messages, because we didn't use the local ids in sorting. So they just werent sorted between each other

Test Plan

run the provided tests

Diff Detail

Repository

rCOMM Comm

Branch

inka/nextLocalID

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Apr 5 2024, 3:05 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 5 2024, 3:05 AM

inka added a parent revision: D11553: [lib][web][native] Remove nextLocalID from redux.Apr 5 2024, 3:28 AM

inka added a child revision: D11565: [lib] Simplify sorting local ids.

Harbormaster completed remote builds in B28017: Diff 38844.Apr 5 2024, 3:33 AM

inka requested review of this revision.Apr 5 2024, 3:33 AM

michal accepted this revision.Apr 5 2024, 6:43 AM

This revision is now accepted and ready to land.Apr 5 2024, 6:43 AM

Closed by commit rCOMM57aa051186e2: [lib] Fix sorting local messages (authored by inka). · Explain WhyApr 5 2024, 7:26 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM57aa051186e2: [lib] Fix sorting local messages.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

4 lines

message-utils.test.js

184 lines

Diff 38844

View Options

lib/shared/message-utils.js