Page MenuHomePhabricator
Differential D11580

[SQLite] update `OlmPersistSession` entity
ClosedPublic
Actions

Authored by kamil on Apr 8 2024, 6:32 AM.
Tags
None
Referenced Files
F3359362: D11580.diff
Sun, Nov 24, 8:45 AM
Unknown Object (File)
Sun, Nov 3, 8:12 AM
Unknown Object (File)
Oct 12 2024, 10:59 PM
Unknown Object (File)
Oct 12 2024, 10:58 PM
Unknown Object (File)
Oct 12 2024, 10:58 PM
Unknown Object (File)
Sep 29 2024, 9:52 AM
Unknown Object (File)
Sep 22 2024, 10:38 AM
Unknown Object (File)
Sep 10 2024, 5:42 PM
View All 29 Files
Subscribers
ashoat

Details

Reviewers
bartek
marcin
tomek
Commits
rCOMM0cd2c0f5cc2a: [SQLite] update `OlmPersistSession` entity
Summary

ENG-7285.
ENG-7034.

Depends on D11577

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
publish-session-resetting
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 8 2024, 6:32 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 8 2024, 6:32 AM
kamil added a child revision: D11582: [native] update C++ crypto module to handle session version.Apr 8 2024, 6:38 AM
Harbormaster completed remote builds in B28052: Diff 38902.Apr 8 2024, 7:00 AM
kamil mentioned this in D11577: [SQLite] add version column to session table & rename to `target_device`.Apr 9 2024, 4:50 AM
kamil published this revision for review.Apr 9 2024, 6:01 AM
marcin accepted this revision.Apr 10 2024, 6:25 AM
marcin added inline comments.
web/shared-worker/worker/worker-crypto.js
105

Hypothetically - if this differential was landed (and potentially released) before the rest of the stack - would it introduce regression because of this line?

This revision is now accepted and ready to land.Apr 10 2024, 6:25 AM
kamil added inline comments.Apr 11 2024, 3:53 AM
web/shared-worker/worker/worker-crypto.js
105

It shouldn't - but I am going to land entire stack at once

kamil updated this revision to Diff 39033.Apr 11 2024, 3:54 AM

rebase

Harbormaster completed remote builds in B28159: Diff 39033.Apr 11 2024, 4:09 AM
Closed by commit rCOMM0cd2c0f5cc2a: [SQLite] update `OlmPersistSession` entity (authored by kamil). · Explain WhyApr 11 2024, 4:47 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0cd2c0f5cc2a: [SQLite] update `OlmPersistSession` entity.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
5 lines
entities/
12 lines
NativeModules/
2 lines
web/
cpp/
5 lines
shared-worker/
_generated/
queries/
35 lines
types/
3 lines
worker/
7 lines

Diff 38902

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/OlmPersistSession.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm-query-executor.js

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/olm-persist-data-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...