[lib] Make synced metadata name field an enum
ClosedPublic
Actions

Authored by will on Apr 10 2024, 11:24 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM051c63bec1d7: [lib] Make synced metadata name field an enum

Summary

Makes the metadata name field an enum for code cleanliness. Future synced metadata types can be included in the enum

Depends on D11627

Test Plan

flow check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 10 2024, 11:24 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 10 2024, 11:24 PM

will edited the summary of this revision. (Show Details)Apr 10 2024, 11:35 PM

will added a parent revision: D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.

Harbormaster completed remote builds in B28154: Diff 39028.Apr 10 2024, 11:39 PM

will requested review of this revision.Apr 10 2024, 11:39 PM

atul accepted this revision.Apr 11 2024, 6:21 PM

This revision is now accepted and ready to land.Apr 11 2024, 6:21 PM

will added a child revision: D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.Apr 12 2024, 9:02 AM

Closed by commit rCOMM051c63bec1d7: [lib] Make synced metadata name field an enum (authored by will). · Explain WhyApr 16 2024, 9:24 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM051c63bec1d7: [lib] Make synced metadata name field an enum.

Revision Contents
Changeset List

Path

Size

lib/

types/

synced-metadata-types.js

11 lines

Diff 39170

View Options

lib/types/synced-metadata-types.js

[lib] Make synced metadata name field an enumClosedPublicActions