[identity] Add verification for replacing a device
ClosedPublic
Actions

Authored by bartek on Mon, Apr 22, 6:46 AM.

Details

Reviewers

varun

Commits

Summary

Added possibility to replace a device in device list

Depends on D11687

Test Plan

Added unit tests
Called UpdateDeviceList RPC with payload that replaced exactly one device - pass
Called UpdateDeviceList RPC with payload that tried to replace primary device - fail

Repository

rCOMM Comm

Branch

barthap/device-list-update

Lint

No Lint Coverage

Unit

No Test Coverage

bartek held this revision as a draft.

bartek published this revision for review.Tue, Apr 23, 11:59 PM

varun added inline comments.

services/identity/src/device_list.rs
106
127	don't we need to make sure that the previous and new device in the replacement are both keyservers?

This revision is now accepted and ready to land.Thu, Apr 25, 10:09 PM

services/identity/src/device_list.rs
127	Yeah this comment is a bit misleading. These validation functions are device-type-agnostic. Generally the logic is going to be extended when we add support for keyserver QR login