Page MenuHomePhabricator
Differential D11791

[native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`
ClosedPublic
Actions

Authored by atul on Thu, Apr 25, 2:00 PM.
Tags
None
Referenced Files
F1791104: D11791.id39582.diff
Sun, May 19, 10:25 AM
F1791103: D11791.id39575.diff
Sun, May 19, 10:25 AM
F1791102: D11791.id39517.diff
Sun, May 19, 10:25 AM
F1791096: D11791.id.diff
Sun, May 19, 10:25 AM
F1791085: D11791.diff
Sun, May 19, 10:24 AM
F1791051: D11791.diff
Sun, May 19, 9:55 AM
Unknown Object (File)
Mon, May 6, 12:26 PM
Unknown Object (File)
Thu, May 2, 11:20 PM
View All 14 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Summary

Similar to D11790, but for ThreadSettings

Depends on D11790

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Thu, Apr 25, 2:00 PM
atul added a child revision: D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.Thu, Apr 25, 2:03 PM
Harbormaster completed remote builds in B28487: Diff 39517.Thu, Apr 25, 2:26 PM
atul requested review of this revision.Thu, Apr 25, 2:26 PM
ashoat accepted this revision.Thu, Apr 25, 2:29 PM
This revision is now accepted and ready to land.Thu, Apr 25, 2:29 PM
atul updated this revision to Diff 39575.Fri, Apr 26, 11:43 AM

land

This revision was landed with ongoing or failed builds.Fri, Apr 26, 11:46 AM
Closed by commit rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in….
Harbormaster completed remote builds in B28528: Diff 39575.Fri, Apr 26, 12:11 PM
atul mentioned this in D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.Fri, Apr 26, 12:49 PM
atul mentioned this in rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in….Thu, May 2, 9:59 AM

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
107 lines

Diff 39575

View Options

native/chat/settings/thread-settings.react.js

Loading...