Paths

Table of Contentst

Differential D12087

[web] Avoid changing height when error occurs in log in screen
ClosedPublic
Actions

Authored by ashoat on May 16 2024, 5:08 PM.

Details

Reviewers

ginsu

Commits

rCOMM73b3c7af4d50: [web] Avoid changing height when error occurs in log in screen

Summary

This diff hardcodes the error to have height: 0, and increases the margin around OrBreak to make up for that. I don't love that asymmetry of this solution when displaying the error, but the extra spacing doesn't look too bad.

OrBreak is used in one other place (SIWELogInForm), so I included a screenshot of that screen in the Test Plan.

Depends on D12086

Test Plan

Screenshot 2024-05-16 at 7.42.06 PM.png (1×852 px, 133 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 16 2024, 5:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 16 2024, 5:08 PM

ashoat added a child revision: D12088: [web] Show alert when login fails due to outdated client version.May 16 2024, 5:09 PM

ashoat edited the test plan for this revision. (Show Details)May 16 2024, 5:10 PM

Harbormaster completed remote builds in B29002: Diff 40311.May 16 2024, 5:32 PM

ashoat requested review of this revision.May 16 2024, 5:32 PM

ginsu accepted this revision.May 17 2024, 12:32 AM

This revision is now accepted and ready to land.May 17 2024, 12:32 AM

Closed by commit rCOMM73b3c7af4d50: [web] Avoid changing height when error occurs in log in screen (authored by ashoat). · Explain WhyMay 17 2024, 6:21 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM73b3c7af4d50: [web] Avoid changing height when error occurs in log in screen.

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.css

1 line

components/

or-break.css

2 lines

Diff 40311

View Options

web/account/log-in-form.css