Paths

Table of Contentst

[web] Rename deviceKeys to qrData in QRCodeLogin
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 3:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 8, 1:46 AM

	Unknown Object (File)
	Aug 9 2024, 9:59 PM

	Unknown Object (File)
	Aug 9 2024, 9:59 PM

	Unknown Object (File)
	Aug 9 2024, 9:59 PM

	Unknown Object (File)
	Aug 9 2024, 9:58 PM

	Unknown Object (File)
	Jul 24 2024, 8:14 AM

	Unknown Object (File)
	Jul 24 2024, 8:13 AM

	Unknown Object (File)
	Jul 24 2024, 8:13 AM

View All 33 Files

Subscribers

tomek

Details

Reviewers

bartek

Commits

rCOMMfbd6ef94049f: [web] Rename deviceKeys to qrData in QRCodeLogin

Summary

This makes it more consistent with QRCodeScreen on native.

Depends on D12109

Test Plan

I tested the flow using staging, with my phone as a primary device and a local simulator as a secondary device

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 20 2024, 3:55 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 3:55 AM

ashoat added a child revision: D12112: [lib][native][web] Convert QRAuthHandler to a hook.May 20 2024, 3:56 AM

Harbormaster completed remote builds in B29047: Diff 40384.May 20 2024, 4:13 AM

ashoat requested review of this revision.May 20 2024, 4:13 AM

bartek accepted this revision.May 20 2024, 5:37 AM

This revision is now accepted and ready to land.May 20 2024, 5:37 AM

Closed by commit rCOMMfbd6ef94049f: [web] Rename deviceKeys to qrData in QRCodeLogin (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfbd6ef94049f: [web] Rename deviceKeys to qrData in QRCodeLogin.

Revision Contents
Changeset List

Path

Size

web/

account/

qr-code-login.react.js

15 lines

Diff 40384

View Options

web/account/qr-code-login.react.js

[web] Rename deviceKeys to qrData in QRCodeLoginClosedPublicActions