This component makes more sense as a hook since it doesn't render anything.
In later diffs I'll refactor it further, and it's helpful to first refactor it to a hook.
Depends on D12110
Paths
| Differential D12112 Authored by ashoat on May 20 2024, 3:56 AM.
Details Summary This component makes more sense as a hook since it doesn't render anything. In later diffs I'll refactor it further, and it's helpful to first refactor it to a hook. Depends on D12110 Test Plan I tested the flow using staging, with my phone as a primary device and a local simulator as a secondary device
Diff Detail
Event TimelineHarbormaster completed remote builds in B29049: Diff 40386.May 20 2024, 4:22 AM2024-05-20 04:22:48 (UTC-7) This revision is now accepted and ready to land.May 20 2024, 6:43 AM2024-05-20 06:43:56 (UTC-7) Closed by commit rCOMMbe592527b708: [lib][native][web] Convert QRAuthHandler to a hook (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM2024-05-21 01:11:19 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 40386 lib/components/qr-auth-handler.react.js
lib/hooks/qr-auth.js
native/qr-code/qr-code-screen.react.js
web/account/qr-code-login.react.js
|