Paths

Table of Contentst

Differential D12176

[blob] Fix Clippy warnings in Blob service
ClosedPublic
Actions

Authored by bartek on May 22 2024, 12:50 PM.

Details

Reviewers

varun

Commits

rCOMM617ea3f3a825: [blob] Fix Clippy warnings in Blob service

Summary

Similiar to D12175 - some warnings in Blob Service.
Mostly about "too large enum varinat" - it suggested boxing error and that's what I did

Depends on D12175

Test Plan

cargo build -p blob

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 22 2024, 12:50 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 22 2024, 12:50 PM

Harbormaster failed remote builds in B29162: Diff 40533!May 22 2024, 12:53 PM

bartek mentioned this in D12178: [rust] Fix Clippy warnings about DateTime.May 22 2024, 12:55 PM

bartek added a child revision: D12178: [rust] Fix Clippy warnings about DateTime.May 22 2024, 2:10 PM

Rebase

Harbormaster completed remote builds in B29172: Diff 40543.May 22 2024, 2:37 PM

bartek published this revision for review.May 22 2024, 2:40 PM

varun accepted this revision.May 22 2024, 2:43 PM

This revision is now accepted and ready to land.May 22 2024, 2:43 PM

Closed by commit rCOMM617ea3f3a825: [blob] Fix Clippy warnings in Blob service. · Explain WhyMay 28 2024, 3:12 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM617ea3f3a825: [blob] Fix Clippy warnings in Blob service.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database/

client.rs

12 lines

errors.rs

4 lines

http/

errors.rs

35 lines

s3.rs

16 lines

Diff 40533

View Options

services/blob/src/database/client.rs

View Options

services/blob/src/database/errors.rs

View Options

services/blob/src/http/errors.rs

View Options

[blob] Fix Clippy warnings in Blob serviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40533

services/blob/src/database/client.rs

services/blob/src/database/errors.rs

services/blob/src/http/errors.rs

services/blob/src/s3.rs

[blob] Fix Clippy warnings in Blob service
ClosedPublic
Actions

Revision Contents
Changeset List