Page MenuHomePhabricator
Differential D12188

[native] Move keyboard logic in LoggedOutModal to function component
ClosedPublic
Actions

Authored by ashoat on May 22 2024, 7:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 1:42 PM
Unknown Object (File)
Mon, Apr 14, 9:45 PM
Unknown Object (File)
Mon, Apr 14, 7:25 PM
Unknown Object (File)
Mon, Apr 14, 2:33 PM
Unknown Object (File)
Sat, Apr 12, 12:40 AM
Unknown Object (File)
Wed, Apr 2, 5:26 PM
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Feb 26 2025, 8:40 AM
View All 74 Files
Subscribers
tomek

Details

Reviewers
inka
Commits
rCOMM94e20f4a797c: [native] Move keyboard logic in LoggedOutModal to function component
Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Depends on D12187

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
80 lines

Diff 40701

View Options

native/account/logged-out-modal.react.js

Show All 12 Lines
import ReportHandler from './report-handler.react.js'; import ReportHandler from './report-handler.react.js';
import RequestResponseHandler from './request-response-handler.react.js'; import RequestResponseHandler from './request-response-handler.react.js';
import UpdateHandler from './update-handler.react.js'; import UpdateHandler from './update-handler.react.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js'; import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js';
import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js';
import type { InitialNotifMessageOptions } from '../shared/crypto-utils.js';
import { import {
pingFrequency, pingFrequency,
serverRequestSocketTimeout, serverRequestSocketTimeout,
clientRequestVisualTimeout, clientRequestVisualTimeout,
clientRequestSocketTimeout, clientRequestSocketTimeout,
} from '../shared/timeouts.js'; } from '../shared/timeouts.js';
import { logInActionSources } from '../types/account-types.js'; import { logInActionSources } from '../types/account-types.js';
import type { CompressedData } from '../types/compression-types.js'; import type { CompressedData } from '../types/compression-types.js';
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Linestype Props = {
+lastCommunicatedPlatformDetails: ?PlatformDetails, +lastCommunicatedPlatformDetails: ?PlatformDetails,
+decompressSocketMessage: CompressedData => string, +decompressSocketMessage: CompressedData => string,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs // async functions that hit server APIs
+socketCrashLoopRecovery?: () => Promise<void>, +socketCrashLoopRecovery?: () => Promise<void>,
// keyserver olm sessions specific props // keyserver olm sessions specific props
+getInitialNotificationsEncryptedMessage?: () => Promise<string>, +getInitialNotificationsEncryptedMessage?: (
options?: ?InitialNotifMessageOptions,
) => Promise<string>,
}; };
type State = { type State = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
}; };
class Socket extends React.PureComponent<Props, State> { class Socket extends React.PureComponent<Props, State> {
state: State = { state: State = {
inflightRequests: null, inflightRequests: null,
}; };
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines