[lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 1:54 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM0050bc8a8abe: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`

Summary

threadFrozenDueToBlock was last callsite of innerThreadFrozenDueToBlock, so inlining and removing innerThreadFrozenDueToBlock altogether.

Depends on D12292

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D12293 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 3 2024, 1:54 PM

atul published this revision for review.Jun 3 2024, 1:54 PM

atul added a child revision: D12294: [lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`.Jun 3 2024, 2:00 PM

Harbormaster completed remote builds in B29401: Diff 40902.Jun 3 2024, 2:25 PM

tomek accepted this revision.Jun 4 2024, 1:56 AM

This revision is now accepted and ready to land.Jun 4 2024, 1:56 AM

ashoat accepted this revision.Jun 4 2024, 11:40 AM

land

This revision was landed with ongoing or failed builds.Jun 16 2024, 7:44 PM

Closed by commit rCOMM0050bc8a8abe: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0050bc8a8abe: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`.

Harbormaster completed remote builds in B29703: Diff 41362.Jun 16 2024, 8:00 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

13 lines

Diff 41362

View Options

lib/shared/thread-utils.js

[lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`ClosedPublicActions