This differential add identity platform details to aux user store and reducer
Details
Flow. running reducer jest test.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/flow-typed/npm/tcomb_v3.x.x.js | ||
---|---|---|
122 ↗ | (On Diff #40920) | Further diffs in this stack use enums.of validator for array of numbers when returning identity response to JS. Additionally without this change flow complained when I used enums.of for array of numbers and after this change it was fixed. Do you think we need additional validation for this change? |
lib/types/identity-service-types.js | ||
333–336 ↗ | (On Diff #40920) | Clearly my oversight. |
Those types are totally wrong. We need mapping from device id to platform details. Interestingly reducer worked as expected - it put map into the SQLite.
lib/flow-typed/npm/tcomb_v3.x.x.js | ||
---|---|---|
122 ↗ | (On Diff #40920) | If later diffs use this validator and it works, then I think that is sufficient for testing |
lib/types/aux-user-types.js | ||
---|---|---|
13 ↗ | (On Diff #40984) | worth noting that all keys in this map are values in the devices array in RawDeviceList above - wondering if there is a better way to type this structure |
lib/types/aux-user-types.js | ||
---|---|---|
13 ↗ | (On Diff #40984) | I talked to @bartek about this and he would rather leave this type as it is. His reasons are:
|