Paths

Table of Contentst

Differential D12279

[grpc_clients] Add platform details metadata
ClosedPublic
Actions

Authored by bartek on Jun 3 2024, 5:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 25, 10:28 PM

	Unknown Object (File)
	Tue, Jun 25, 4:51 PM

	Unknown Object (File)
	Wed, Jun 19, 3:41 PM

	Unknown Object (File)
	Sun, Jun 16, 10:43 PM

	Unknown Object (File)
	Sat, Jun 15, 11:36 AM

	Unknown Object (File)
	Fri, Jun 14, 8:54 AM

	Unknown Object (File)
	Fri, Jun 14, 8:00 AM

	Unknown Object (File)
	Fri, Jun 14, 7:14 AM

View All 19 Files

Subscribers

Details

Reviewers

varun
marcin

Commits

rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata

Summary

Updated ClientVersionLayer to pass additional metadata params

Depends on D12275

Test Plan

Tested together with next diffs

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 3 2024, 5:36 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 3 2024, 5:36 AM

bartek added a child revision: D12280: [web] Add platform details metadata.Jun 3 2024, 5:37 AM

Harbormaster completed remote builds in B29360: Diff 40845.Jun 3 2024, 5:52 AM

bartek published this revision for review.Jun 3 2024, 6:01 AM

marcin added inline comments.Jun 4 2024, 9:09 AM

shared/grpc_clients/src/identity/shared.rs
7 ↗	(On Diff #40845)	Isn't it possible to use already defined `PlatformDetails` here?

bartek added inline comments.Jun 6 2024, 12:08 AM

shared/grpc_clients/src/identity/shared.rs
7 ↗	(On Diff #40845)	It is, but wanted to keep both types separate because `CodeVersionLayer` is also used as a type in gRPC configs and in the future it might be changed separately to `PlatformMetadata`

bartek mentioned this in D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.Jun 6 2024, 12:09 AM

marcin accepted this revision.Jun 6 2024, 2:08 AM

This revision is now accepted and ready to land.Jun 6 2024, 2:08 AM

Closed by commit rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata (authored by bartek). · Explain WhyThu, Jun 6, 8:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata.

Revision Contents
Changeset List

Path

Size

shared/

grpc_clients/

src/

identity/

authenticated.rs

4 lines

14 lines

unauthenticated/

4 lines

Diff 41051

shared/grpc_clients/src/identity/authenticated.rs

Loading...

shared/grpc_clients/src/identity/shared.rs

Loading...

shared/grpc_clients/src/identity/unauthenticated/mod.rs

Loading...