Page MenuHomePhabricator
Differential D12279

[grpc_clients] Add platform details metadata
ClosedPublic
Actions

Authored by bartek on Jun 3 2024, 5:36 AM.
Tags
None
Referenced Files
F2236639: D12279.id41051.diff
Thu, Jul 11, 2:27 AM
F2236638: D12279.id40845.diff
Thu, Jul 11, 2:27 AM
F2236527: D12279.id.diff
Thu, Jul 11, 2:26 AM
F2236447: D12279.diff
Thu, Jul 11, 2:24 AM
Unknown Object (File)
Sun, Jul 7, 12:43 PM
Unknown Object (File)
Tue, Jun 25, 10:28 PM
Unknown Object (File)
Tue, Jun 25, 4:51 PM
Unknown Object (File)
Wed, Jun 19, 3:41 PM
View All 24 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
marcin
Commits
rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata
Summary

Updated ClientVersionLayer to pass additional metadata params

Depends on D12275

Test Plan

Tested together with next diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 3 2024, 5:36 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 3 2024, 5:36 AM
bartek added a child revision: D12280: [web] Add platform details metadata.Jun 3 2024, 5:37 AM
Harbormaster completed remote builds in B29360: Diff 40845.Jun 3 2024, 5:52 AM
bartek published this revision for review.Jun 3 2024, 6:01 AM
marcin added inline comments.Jun 4 2024, 9:09 AM
shared/grpc_clients/src/identity/shared.rs
7

Isn't it possible to use already defined PlatformDetails here?

bartek added inline comments.Jun 6 2024, 12:08 AM
shared/grpc_clients/src/identity/shared.rs
7

It is, but wanted to keep both types separate because CodeVersionLayer is also used as a type in gRPC configs and in the future it might be changed separately to PlatformMetadata

bartek mentioned this in D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.Jun 6 2024, 12:09 AM
marcin accepted this revision.Jun 6 2024, 2:08 AM
This revision is now accepted and ready to land.Jun 6 2024, 2:08 AM
Closed by commit rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata (authored by bartek). · Explain WhyJun 6 2024, 8:11 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata.

Revision Contents
Changeset List

PathSize
shared/
grpc_clients/
src/
identity/
4 lines
14 lines
unauthenticated/
4 lines

Diff 40845

View Options

shared/grpc_clients/src/identity/authenticated.rs

Loading...
View Options

shared/grpc_clients/src/identity/shared.rs

Loading...
View Options

shared/grpc_clients/src/identity/unauthenticated/mod.rs

Loading...